Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load plugin object style without options object #9647

Merged
merged 4 commits into from
Nov 2, 2018

Conversation

zvinless
Copy link
Contributor

@zvinless zvinless commented Nov 1, 2018

Fixes issue at the end of #9559, e.g.:

module.exports = {
    plugins: [
        {
            resolve: 'gatsby-plugin-react-helmet'
        }
    ]
}

where the plugin is loaded using object syntax but no options object is defined.

This wasn't caught by the unit test because the issue was occurring after the early out when it's the ___TEST___ plugin.

@zvinless zvinless requested a review from a team as a code owner November 1, 2018 23:01
@zvinless zvinless changed the title Fix/load plugin without options Fix: load plugin object style without options object Nov 1, 2018
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zvinless!

@pieh pieh changed the title Fix: load plugin object style without options object fix: load plugin object style without options object Nov 2, 2018
@pieh pieh merged commit 42a2d07 into gatsbyjs:master Nov 2, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 2, 2018

Holy buckets, @zvinless — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

Fixes issue at the end of gatsbyjs#9559, e.g.:
```javascript
module.exports = {
    plugins: [
        {
            resolve: 'gatsby-plugin-react-helmet'
        }
    ]
}
```
where the plugin is loaded using object syntax but no `options` object is defined.

This wasn't caught by the unit test because the issue was occurring after the early out when it's the `___TEST___` plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants