-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load plugin object style without options object #9647
fix: load plugin object style without options object #9647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zvinless!
Holy buckets, @zvinless — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
<!-- Q. Which branch should I use for my pull request? A. Use `master` branch (probably). Q. Which branch if my change is a bug fix for Gatsby v1? A. In this case, you should use the `v1` branch Q. Which branch if I'm still not sure? A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ --> Fixes issue at the end of gatsbyjs#9559, e.g.: ```javascript module.exports = { plugins: [ { resolve: 'gatsby-plugin-react-helmet' } ] } ``` where the plugin is loaded using object syntax but no `options` object is defined. This wasn't caught by the unit test because the issue was occurring after the early out when it's the `___TEST___` plugin.
Fixes issue at the end of #9559, e.g.:
where the plugin is loaded using object syntax but no
options
object is defined.This wasn't caught by the unit test because the issue was occurring after the early out when it's the
___TEST___
plugin.