Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unused images from docs/tutorials #9686

Merged
merged 2 commits into from
Nov 4, 2018
Merged

docs: remove unused images from docs/tutorials #9686

merged 2 commits into from
Nov 4, 2018

Conversation

barrymcgee
Copy link
Contributor

Done 🙌🏻

While I was doing some digging for #9655, I noticed the tutorial folders contained redundant image files that were no longer being used anywhere in the codebase. I have removed them.

Why? 🧐

  • This is a huge codebase, cloning it to my machine took ten minutes. Removing any redundant files will help, albeit only a little. But every little helps, right? 👍🏻

  • It easier to maintain a site which only contains files that are being used as there is less cognitive overload.

How to QA this change 🤓

  • Grep the codebase for each file I have deleted
  • You should return 0 results for each file.

@barrymcgee barrymcgee requested a review from a team November 3, 2018 20:51
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

They still will be in git history if someone doesn't do shallow clone (with --depth arg when cloning, but we do encourage using that in our how to contribute docs)

@pieh pieh changed the title Removed unused images from docs/tutorials docs: remove unused images from docs/tutorials Nov 4, 2018
@pieh pieh merged commit f6ed2f0 into gatsbyjs:master Nov 4, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 4, 2018

Holy buckets, @barrymcgee — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@barrymcgee barrymcgee deleted the removed-unused-tut-images branch November 4, 2018 16:13
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
## Done 🙌🏻

While I was doing some digging for gatsbyjs#9655, I noticed the tutorial folders contained redundant image files that were no longer being used anywhere in the codebase. I have removed them.

## Why? 🧐

- This is a huge codebase, cloning it to my machine took ten minutes. Removing any redundant files will help, albeit only a little. But every little helps, right? 👍🏻

- It easier to maintain a site which only contains files that are being used as there is less cognitive overload.

## How to QA this change 🤓

- Grep the codebase for each file I have deleted
- You should return 0 results for each file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants