Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve spacing of dependency grid in starter detail page #10131

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

leolabs
Copy link
Contributor

@leolabs leolabs commented Nov 26, 2018

The spacing in the dependency grid looked off to me, so I improved it a bit.

Before:
screenshot 2018-11-26 at 13 58 19

After:
screenshot 2018-11-26 at 13 58 07

@leolabs leolabs requested a review from a team as a code owner November 26, 2018 13:02
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable; thank you!

@DSchau DSchau merged commit 55a299d into master Nov 26, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…yjs#10131)

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

The spacing in the dependency grid looked off to me, so I improved it a bit.

Before: 
<img width="1064" alt="screenshot 2018-11-26 at 13 58 19" src="https://user-images.githubusercontent.com/541628/49015578-cbfa7a00-f183-11e8-9ee0-2452f8c1c83d.png">

After: 
<img width="1079" alt="screenshot 2018-11-26 at 13 58 07" src="https://user-images.githubusercontent.com/541628/49015584-d157c480-f183-11e8-86de-b7c20bee71f8.png">
@wardpeet wardpeet deleted the fix/starter-detail-dependency-grid branch March 18, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants