Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.0 #1599

Merged
merged 34 commits into from
Jan 30, 2023
Merged

Release 1.4.0 #1599

merged 34 commits into from
Jan 30, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Jan 26, 2023

Features

Improvements

Major fixes

Minor fixes

Tests

Issues

mmv08 and others added 30 commits January 11, 2023 17:20
* fix: set a local loading state for when the input is filled in setValueAs

* use local isValidating instead of useFormContext
* fix: wait until successful SDK call to set pending state

* fix tests. remove duplicated test

* move other dispatch EXECUTING calls after the SDK call

* dispatch ONCHAIN_SIGNATURE_REQUESTED event after calling the SDK
* Feat: explorer link for unproposed txs

* View on etherecan.io -> View on explorer
* style: AB buttons under the searchbar

* use Card in mobile viewports

* fix col span

* display TableCard in smaller viewports

* fix button padding

* improve Card hover styles. Fix buttons padding

* revert passing a table card component

* Update src/components/common/EnhancedTable/styles.module.css

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>

Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>
* refactor: replace Stepper for MUI List. Prefer custom svg over MUI icons

* fix leftover naming

* replace MUI icons by custom svgs

* use sx palette

* fix isConfirmed logic
…wallet connect event (#1547)

* fix: GA tracking wrong eventLabels, missing event type, overtracking wallet connect

* fix: Track all event types
* fix: Remove last used wallet when disconnecting

* refactor: Add function instead of exporting the storage
* fix: position executor in transaction stepper

* fix: remove lint style

* fix: simplify styling
* txinfo-props-issue

* fixes- #1524
* fix: ref forwarding

* fix: add width
* fix: Reduce cummulative layout shift (CLS)

* fix: Revert manifest change

* fix: Remove Box and fallback
* feat: add smoke test for spending limit modal

* fix: move out of smokes
* fix: "Recipient" -> "Recipient address or ENS"

* Move it to AddressInput
* fix: sending from nesting error

* fix: use Typography with specified `component`
* fixes- #1523

* reviewed-changes #1523

* reviewed-changes2 #1523

* reviewed-changes3 #1523
* fix: `merge` hydration of persisted state

* fix: add tests

* fix: add explanatory comment + test

* fix: update comment

* fix: adjust comment

Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>

* fix: remove redundant assignment

Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>
* fix: reset error boundary after navigation

* fix: imports

* fix: import order

* fix: change to a standard link
* fix: fallback to `chainId` of `wallet`

* fix: prioritise wallet chain id + add test

* fix: mock
* Fix: reset amount field on token select

* fix: use `Controller`

Co-authored-by: katspaugh <katspaugh@gmail.com>
* Add increment for failing estimations in Gnosis Chain

* use config/chains

* update comment

* update parameters semantics

* Update CLA allowlist
* fix: iterate signing method on error

* fix: comment

* fix: test

* fix: take Safe version into account

* fix: only use `eth_signTypedData_v4` + reorganise

* fix: use `eth_signTypedData` + remove extra check

* fix: move comment

* fix: remove log

* fix: clarify test comment

* refactor: `return` earlier

* fix: tests + constants

* fix: add `throw`
* Fix: propose immediately executed txs

* Rm txId from the onSubmit params
* Feat: support 1.0.0 Safes

* Fix tests

* fix: upgrading

* fix: correct error message

Co-authored-by: iamacook <aaron@safe.global>
@github-actions
Copy link

github-actions bot commented Jan 26, 2023

Branch preview

✅ Deploy successful!

https://release_1_4_0--webcore.review-web-core.5afe.dev

@katspaugh katspaugh mentioned this pull request Jan 26, 2023
@github-actions
Copy link

github-actions bot commented Jan 26, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

francovenica commented Jan 26, 2023

I was able to corroborate the 30% increase in value for the GNO chain. The amount increased is the gas limit whenever the safeTxGas != 0. Dani Sanchez helped me out with the corroboration. Looks fine
image

* fix: migrate/sanitise legacy owner format

* fix: test

* fix: check structure, checksum + add tests

* fix: rename action

* fix: alter production flag

* fix: revert production flag change
@francovenica
Copy link
Contributor

Ok, The RC looks good. It seems the Token counter issue is still to be merged, but after that It can be deployed

@katspaugh katspaugh merged commit bb6fa15 into main Jan 30, 2023
@katspaugh katspaugh deleted the release/1.4.0 branch January 30, 2023 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants