Fix: default wallet when none are enabled #1597
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
| const enabledWallets = Object.entries(WALLET_MODULES).filter(([key]) => isWalletSupported(chain.disabledWallets, key)) | ||
|
|
||
| if (enabledWallets.length === 0) { | ||
| return [WALLET_MODULES.INJECTED()] |
There was a problem hiding this comment.
MetaMask can be disabled:
We should probably return an empty array here, as well as filter the "recommended injected wallets" in getRecommendedInjectedWallets. What do you think?
There was a problem hiding this comment.
I think you're thinking too much into it. In practice, no chain will have all wallets disabled, and defaulting to the injected wallet is a quick and pragmatic solution w/o adding too many conditions IMHO.
There was a problem hiding this comment.
We should remove MetaMask from the list of wallets that can be disabled when we eventually remove the "legacy" wallet names then.
|
verified |
What it solves
Resolves #1596
How this PR fixes it
When all wallets are disabled, we pass an empty array to onboard, but it needs at least one wallet. So I made it return the "injected" wallet as a default.
How to test it
Cello has currently 0 wallets enabled in the staging config.