fix: prevent scrollbars on Safe App icons #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://safe_app_icon_scrollbars--webcore.review-web-core.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Jan 19, 2023
| @@ -4,7 +4,7 @@ const APP_LOGO_FALLBACK_IMAGE = `/images/apps/app-placeholder.svg` | |||
|
|
|||
| const getIframeContent = (url: string, width: number, height: number): string => { | |||
| return ` | |||
| <body style="margin: 0;"> | |||
| <body style="margin: 0; overflow: hidden;"> | |||
There was a problem hiding this comment.
@mikhailxyz display block on the image would probably make this fix unnecessary.
katspaugh
approved these changes
Jan 19, 2023
mmv08
approved these changes
Jan 19, 2023
usame-algan
approved these changes
Jan 19, 2023
|
Tested, no scrollbars! ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1564
How this PR fixes it
The
overflowof theSafeAppIconis nothidden.How to test it
Open the Safe Apps page and observe no scrollbars on icons.
Screenshots