fix: Handle safe creation errors

[usame-algan]

What it solves

Resolves #1558

Note: I couldn't reproduce ethers returning an error but the transaction still being executed/being in the mempool.

How this PR fixes it

Uses the generic ERROR instead of TIMEOUT as a fall-through when creating a safe. This makes more sense since ethers returns a specific error code for timeouts but not for other possible errors like the one reported.

How to test it

1. Create a new safe
2. Select 21000 gas limit in your wallet
3. Submit transaction
4. Observe a generic error in the UI instead of a timeout error
5. Create a new safe
6. Select extremely low gas and maxPrioFee
7. Reload the page
8. Wait for 6.5 minutes
9. Observe a timeout error

[github-actions]

Branch preview

✅ Deploy successful!

https://fix_safe_creation_error--webcore.review-web-core.5afe.dev

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[iamacook]

Looks good to me.

With the gas set to 21000, the wallet shows a generic error:

Setting a low gas/maxPrioFee and refreshing also resulted in a timeout after 6.5 minutes: (I made sure that the experimental gas UI is turned on in MetaMask.)

[DiogoSoaress]

The fix makes sure we display only a timeout error if that's what we get from ethers. A generic error otherwise is more correct 👍

[francovenica]

It works fine for me as well, but the timeout I had to test it in another network, since in arbitrum what ever number you set in the gas price and fee the tx will fail right away or succeed, there is no in between