Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EthHashInfo nesting #1590

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: EthHashInfo nesting #1590

merged 1 commit into from
Jan 24, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves invalid DOM nested, on top of #1585

image

How this PR fixes it

All instances of EthHashInfo found inside Typography have been changed to use div elements as they shouldn't be nested inside p elements.

How to test it

  1. Open the account centre when connected to a wallet without an ENS and observe no console error.
  2. Load a Safe and observe no console errors on the owner overview step.
  3. Review a transaction to be created and observe console errors.

@iamacook iamacook self-assigned this Jan 24, 2023
@github-actions
Copy link

github-actions bot commented Jan 24, 2023

Branch preview

✅ Deploy successful!

https://fix_nesting--webcore.review-web-core.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook
Copy link
Member Author

I'll merge this directly as it just fixes console errors and I've tested it.

@iamacook iamacook merged commit 5f7336f into dev Jan 24, 2023
@iamacook iamacook deleted the fix-nesting branch January 24, 2023 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants