Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Extend create safe e2e test #1543

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix: Extend create safe e2e test #1543

merged 1 commit into from
Jan 13, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jan 13, 2023 •
edited
Loading

What it solves

Follow up on #1500

Tests more cases during safe creation flow:

  • Changing network
  • Removing an owner
  • Saving data even when going back

@github-actions
Copy link

github-actions bot commented Jan 13, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://create_safe_e2e_2--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 13, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

katspaugh
katspaugh approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@usame-algan usame-algan merged commit 9694877 into dev Jan 13, 2023
@usame-algan usame-algan deleted the create-safe-e2e-2 branch January 13, 2023 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usame-algan @katspaugh