Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTM tracking] - Mobile pairing is being tracked multiple times #1600

Closed
francovenica opened this issue Jan 26, 2023 · 0 comments · Fixed by #1605
Closed

[GTM tracking] - Mobile pairing is being tracked multiple times #1600

francovenica opened this issue Jan 26, 2023 · 0 comments · Fixed by #1605
Assignees
@iamacook
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@francovenica
Copy link
Contributor

Bug description

When a wallet is connected it is tracked in the GTM. That track should happen once. For mobile pairing with the safe mobile app that tracking happens twice, and even more times if other wallets are also currently connected to the app

Environment

  • Browser: Chrome
  • Wallet: Safe mobile (mobile pairing)
  • Chain: Any
  • Env: RC 1.4.0 Release 1.4.0 #1599

Steps to reproduce

  1. Go to the app and turn on analytics. Open the dev console

  2. Connect with mobile pairing (result 1)

  3. Disconnect all wallets

  4. Connect with MM first, then with Trezor (or ledger) so you can swith between both

  5. Connect with mobile pairing (result 2)

Expected result

The event "Connect wallet" should happen once.

Obtained result

1 - The event is triggered twice
2 - The event is triggered multiple times, (up to 5 times in some cases)

Screenshots

safe mobile connect
@francovenica francovenica added the bug Something isn't working label Jan 26, 2023
@francovenica francovenica added this to the 1.4.0 milestone Jan 26, 2023
@francovenica francovenica mentioned this issue Jan 26, 2023
Merged
2 tasks
@iamacook iamacook self-assigned this Jan 27, 2023
@iamacook iamacook mentioned this issue Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamacook iamacook

Labels
bug Something isn't working
Projects
Web Squad
Archived in project
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

fix: prevent multiple pairing tracking calls safe-global/safe-wallet-web
2 participants
@francovenica @iamacook