Support Rails 6.0

[chessbyte]

Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#179

Pull Requests

• Rails 6.0 #20778
• Rails 6.0 manageiq-api#963
• Rails 6.0 manageiq-gems-pending#503
• Rails 6.0 manageiq-graphql#96
• Rails 6.0 manageiq-postgres_ha_admin#23
• Rails 6.0 manageiq-providers-openstack#663
• Rails 6.0 manageiq-providers-lenovo#322
• Rails 6.0 manageiq-providers-ansible_tower#246
• Rails 6.0 manageiq-schema#531
• Rails 6.0 manageiq-ui-classic#7481
• Rails 6.0 activerecord-id_regions#18
• Rails 6.0 inventory_refresh#95
• Rails 6.0 Support manageiq-messaging#59
• Rails 6.0 ovirt_metrics#35
• Rails 6.0 vmware_web_service#90

Current PRs

Individual PRs, or commits pulled out of the base branches that can be merged prior to upgrading to Rails 6.

• [rails6][Gemfile] Upgrade hamlit: [rails6][Gemfile] Upgrade hamlit #20722
• [rails6][service_template_ansible_playbook_spec.rb] Fix ems/provider lets: [rails6][service_template_ansible_playbook_spec.rb] Fix ems/provider lets #20787
  • Fixes ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection error
• [rails6][git_repository_spec.rb] Use .local_miq_server: [rails6][git_repository_spec.rb] Use .local_miq_server #20794
• [rails6][catalog_controller_spec.rb] Fix ems let: [rails6][catalog_controller_spec.rb] Fix ems let manageiq-ui-classic#7500
  • Follow up: Disable :embedded_automation_manager_ansible factory #20816
• Fix rake test:vmdb:setup: [rails6] Fix evm:dbsync:resync_excludes #20841
• (Draft)(Closed)(Not Needed?) Add missing includes of the supports mixin: Add missing includes of the supports mixin manageiq-providers-ibm_terraform#40

TODO

• Release external gems:
  • activerecord-id_regions (requires Rails 6.0 activerecord-id_regions#18 )
  • inventory_refresh ( requires Rails 6.0 inventory_refresh#95 )
  • ovirt_metrics ( requires Rails 6.0 ovirt_metrics#35 )
  • manageiq-messaging ( requires Rails 6.0 Support manageiq-messaging#59 )
  • manageiq-postgres_ha_admin ( requires Rails 6.0 manageiq-postgres_ha_admin#23 )
  • vmware_web_service ( requires Rails 6.0 vmware_web_service#90 )
• Fix ManageIQ/manageiq-graphql ( Rails 6.0 manageiq-graphql#96 )
  • Fixed via ManageIQ/graphql-preload@03466e1
• Fix ManageIQ/jquery-rjs
  • Updates for Rails 6.0 jquery-rjs#2 Updates for Rails 6.0 jquery-rjs#3
  • Release new version?

Done

✅ ManageIQ/manageiq tests to fix

ManageIQ/manageiq tests to fix:

• expected block to not output to stderr, but output "DEPRECATION WARNING: ..."

  1) TaskHelpers::Imports::Tags#import when the source is a directory imports all .yaml files in a specified directory
    Failure/Error:
       expect do
         TaskHelpers::Imports::Tags.new.import(options)
       end.to_not output.to_stderr
  
       expected block to not output to stderr, but output "DEPRECATION WARNING: Class level methods will no longer inherit scoping from `create` in Rails 6.1. ...os/NickLaMuro/manageiq@128d078f12e7edef3f81d543e50a335300d65ed1/app/models/classification.rb:512)\n"
  
    # ./spec/lib/task_helpers/imports/tags_spec.rb:22:in `block (4 levels) in <top (required)>'
  

  (actually happens in app/models/classification.rb)

• Invalid SQL in expectation for miq_expression_spec.rb

• Hash keys as expected as symbols, but are strings in dialog_field_serializer_spec.rb

• ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection:

  ( fixed by [rails6][service_template_ansible_playbook_spec.rb] Fix ems/provider lets #20787 )

  5) ServiceTemplateAnsiblePlaybook.create_catalog_item creates and returns a catalog item
  
     Failure/Error: factory_exists?(factory) ? super : class_from_symbol(factory).create!(*args)
  
     ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection:
  
       Cannot modify association 'ManageIQ::Providers::EmbeddedAnsible::Provider#endpoints' because the source reflection class 'Endpoint' is associated to 'ExtManagementSystem' via :has_many.
  
     # ./spec/support/missing_factory_helper.rb:10:in `create'
     # ./spec/models/service_template_ansible_playbook_spec.rb:11:in `block (2 levels) in <top (required)>'
     # ./spec/models/service_template_ansible_playbook_spec.rb:7:in `block (2 levels) in <top (required)>'
     # ./spec/models/service_template_ansible_playbook_spec.rb:15:in `block (2 levels) in <top (required)>'
     # ./spec/models/service_template_ansible_playbook_spec.rb:40:in `block (2 levels) in <top (required)>'
     # ./spec/models/service_template_ansible_playbook_spec.rb:47:in `block (2 levels) in <top (required)>'
     # ./spec/models/service_template_ansible_playbook_spec.rb:82:in `block (3 levels) in <top (required)>'
  

• ActiveRecord::RecordInvalid: Validation failed: ( Fixed by [rails6][git_repository_spec.rb] Use .local_miq_server #20794 )

  14) GitRepository repo parameter check userid and password is set
  
     Failure/Error: save!
  
     ActiveRecord::RecordInvalid:
       Validation failed: 
  
     # ./app/models/git_repository.rb:34:in `block in refresh'
     # ./app/models/git_repository.rb:30:in `refresh'
     # ./spec/models/git_repository_spec.rb:91:in `block (4 levels) in <top (required)>'
  

• ArgumentError: wrong number of arguments (given 1, expected 2)

  16) EvmApplication.encryption_key_valid? returns true when we are using the correct encryption key
     Failure/Error: context = ActiveRecord::MigrationContext.new('db/migrate')
  
     ArgumentError:
       wrong number of arguments (given 1, expected 2)
  
     # ./lib/tasks/evm_application.rb:205:in `new'
     # ./lib/tasks/evm_application.rb:205:in `deployment_status'
     # ./lib/tasks/evm_application.rb:192:in `encryption_key_valid?'
     # ./spec/lib/tasks/evm_application_spec.rb:358:in `block (3 levels) in <top (required)>'
  

[himdel]

Ping me if this becomes important, this will depend on ManageIQ/manageiq-ui-classic#5679

[jrafanie]

Ping me if this becomes important, this will depend on ManageIQ/manageiq-ui-classic#5679

It will be once we get past the rails 5.2 errors cc @kbrock

[NickLaMuro]

I shared this privately, but I pushed a branch to "very early start on this" here:

https://github.com/NickLaMuro/manageiq/tree/rails-6

There are a bunch of related rails-6 branches in the Gemfile as well that were needed, but I basically got to the point of allowing it to bundle, but that is it (and I haven't touched it since the beginning of May).

[NickLaMuro]

I think the last fix we needed to allow things to work was the manageiq-messaging change above, and with that in place (prior to it being released), it passed:

• https://github.com/ManageIQ/manageiq-cross_repo-tests/runs/1646448237
• https://travis-ci.com/github/ManageIQ/manageiq-cross_repo-tests/builds/211851628

The next build following it being merged (and the upgrade PR being removed, meaning it is using rubygems now):

https://travis-ci.com/github/ManageIQ/manageiq-cross_repo-tests/builds/212022840

Is starting to pass, so I expect that we are good to merge everything else in one fell swoop.

[NickLaMuro]

Okay. Looks like after getting a second merge in of master into manageiq-ui-classic, tests our now passing again in manageiq-cross_repo-tests:

• https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/179/checks
• https://travis-ci.com/github/ManageIQ/manageiq-cross_repo-tests/builds/212218387

[Fryguy]

Merged!