Updates for Rails 6.0 #2
Conversation
In Rails6, there is a deprecation warning with `.call` when working with
template handlers:
DEPRECATION WARNING: Single arity template handlers are deprecated.
Template handlers must now accept two parameters, the view object and the
source for the view object.
Change:
>> #<ActionView::Template::Handlers::RJS:0x00007f8ecf616cb8>.call(template)
To:
>> #<ActionView::Template::Handlers::RJS:0x00007f8ecf616cb8>.call(template, source)
This borrows from PR 138 in Hamlit that did the same thing:
- https://github.com/k0kubun/hamlit
- https://github.com/k0kubun/hamlit/blob/master/CHANGELOG.md#293---2019-04-09
While using the `Module.prepend` approach is probably the correct way to do this, the way that this class is defined is pretty gross, so I would rather avoid trying to deal with that and simply replicate the functionality `alias_method_chain` provided by doing two `alias_method` calls. This is a Gem the probably should just die anyway, so I am not terribly bothered by the hack...
|
|
||
| alias_method :render_without_update, :render |
There was a problem hiding this comment.
@bdunne see my commit message for this:
[rails6] replace alias_method_chain
While using the
Module.prependapproach is probably the correct way to
do this, the way that this class is defined is pretty gross, so I would
rather avoid trying to deal with that and simply replicate the
functionalityalias_method_chainprovided by doing twoalias_method
calls.This is a Gem the probably should just die anyway, so I am not terribly
bothered by the hack...
There was a problem hiding this comment.
Also, since this is mostly just to maintain legacy code, I am trying to do the least amount of changes possible, and using prepend is doing more refactoring than I would like, where this approach is basically taking what alias_method_chain did and doing it manually.
|
@NickLaMuro These changes are going to the master branch, but we don't use the master branch...you'll have to put your changes on the |
|
@Fryguy Balls.... looks like I have to redo this then... Anyway, will open up a new version of this PR. Thanks. |
alias_method_chainActionView::Template::Handlers::RJS.callProbably should be a major version update for this gem, but that can be up for discussion.