[catalog_controller_spec.rb] Fix ems let... again #7508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
force-pushed
the
rails6_fix_has_many_through_factory_errors_part_deux
branch
from
f3fadd9
to
ee6461a
Compare
|
Seems to be a bunch of failures across That said, the current job at the time of writing: https://github.com/ManageIQ/manageiq-ui-classic/runs/1397568112 Is only failing on |
This is a follow up to 02e4b85 as the solution provided there, while works for this use case, ended up causing problems in `ManageIQ/manageiq-content`: ManageIQ/manageiq#20787 (comment) Instead, we use the :provider_embedded_ansible factory, and reference the `.automation_manager` from that. In addition, since a update to the `:inventory_root_groups` was needed, we also modify the record in a `before` statement as well. This ends up not being as clean as the previous implementation, but makes sure we are using the `EmbeddedAnsible` provider in the form that it would be called when used in the application.
NickLaMuro
force-pushed
the
rails6_fix_has_many_through_factory_errors_part_deux
branch
from
ee6461a
to
16b4501
Compare
|
Checked commit NickLaMuro@16b4501 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint spec/controllers/catalog_controller_spec.rb
|
|
@himdel and/or @h-kataria : Could one of you take a look at this now that specs (on master) are passing again? |
NickLaMuro
added a commit
to NickLaMuro/manageiq-ui-classic
that referenced
this pull request
Nov 16, 2020
Merge ManageIQ#7508 instead! This is a follow up to 02e4b85 as the solution provided there, while works for this use case, ended up causing problems in `ManageIQ/manageiq-content`: ManageIQ/manageiq#20787 (comment) Instead, we use the :provider_embedded_ansible factory, and reference the `.automation_manager` from that. In addition, since a update to the `:inventory_root_groups` was needed, we also modify the record in a `before` statement as well. This ends up not being as clean as the previous implementation, but makes sure we are using the `EmbeddedAnsible` provider in the form that it would be called when used in the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to 02e4b85 (aka: #7500 ) as the solution provided there, while works for this use case, ended up causing problems in
ManageIQ/manageiq-content:ManageIQ/manageiq#20787 (comment)
Instead, we use the
:provider_embedded_ansiblefactory, and reference the.automation_managerfrom that. In addition, since a update to the:inventory_root_groupswas needed, we also modify the record in abeforestatement as well.This ends up not being as clean as the previous implementation, but makes sure we are using the
EmbeddedAnsibleprovider in the form that it would be called when used in the application.Links