[rails6] Use relative paths for layouts #7574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
force-pushed
the
rails-6-use-relative-paths-for-layouts
branch
from
5c54c66
to
9b25a97
Compare
NickLaMuro
force-pushed
the
rails-6-use-relative-paths-for-layouts
branch
2 times, most recently
from
7bc19c2
to
b934fb2
Compare
Fixes the following Deprecation warnings: DEPRECATION WARNING: Rendering layouts from an absolute path is deprecated. (called from render_pdf_internal_rr at /home/travis/build/ManageIQ/manageiq-ui-classic/app/controllers/application_controller/report_downloads.rb:47) DEPRECATION WARNING: Rendering layouts from an absolute path is deprecated. (called from print_report at /Users/nicklamuro/code/redhat/manageiq-ui-classic/app/controllers/application_controller/report_downloads.rb:124) DEPRECATION WARNING: Rendering layouts from an absolute path is deprecated. (called from set_summary_pdf_data at /home/travis/build/ManageIQ/manageiq-ui-classic/app/controllers/application_controller/report_downloads.rb:234) Caused by the Rails 6.0 Upgrade
NickLaMuro
force-pushed
the
rails-6-use-relative-paths-for-layouts
branch
from
b934fb2
to
d2f1b4f
Compare
|
Checked commit NickLaMuro@d2f1b4f with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
h-kataria
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following Deprecation warnings:
Caused by the Rails 6.0 Upgrade
Note for reviewers
The specs that are fixed here are not the only specs that are exercising this code, just the specs that check for method arguments to be exact, and fail after the changes to the
app/controllers/**code. There are plenty of tests calling this code causing the original deprecation warnings:https://travis-ci.com/github/ManageIQ/manageiq-ui-classic/jobs/470572340#L2105-L2135
So my guess would be that this is probably a safe change, though it wouldn't hurt to have someone who knows better where this layout is used on a screen to confirm.
Links