[rails6][git_repository_spec.rb] Use .local_miq_server #20794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 6, it seems like a validation callback for nested relations is causing a `GitRepository.save!` to fail. In this case, a MiqQueue call validation that checks that the `Zone` that is being provided via the `options` to queue the work on actually exists. This seems to have not been respected properly in the past, so this fix just simply switches to using actually `MiqServer`/`Zone` records instead of trying to stub them out. Works in both Rails 5.2 and Rails 6.0
|
Checked commit NickLaMuro@0aff5f2 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Fryguy
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 6, it seems like a validation callback for nested relations is causing a
GitRepository.save!to fail. In this case, a MiqQueue call validation that checks that theZonethat is being provided via theoptionsto queue the work on actually exists.This seems to have not been respected properly in the past, so this fix just simply switches to using actually
MiqServer/Zonerecords instead of trying to stub them out.Works in both Rails 5.2 and Rails 6.0
Links