[rails6][service_template_ansible_playbook_spec.rb] Fix ems/provider lets

[NickLaMuro]

This fix takes a page from a PR from @skateman:

#20031

Which was that instead of trying to assign the provider prior to making the EMS in the factories, default a provider object type as part of the ext_management_system child definition, and reference it in the let(:provider).

This is not a problem in Rails 5.2, but does lead to the following error in Rails 6.0

5) ServiceTemplateAnsiblePlaybook.create_catalog_item creates and returns a catalog item

   Failure/Error: factory_exists?(factory) ? super : class_from_symbol(factory).create!(*args)

   ActiveRecord::HasManyThroughCantAssociateThroughHasOneOrManyReflection:

     Cannot modify association 'ManageIQ::Providers::EmbeddedAnsible::Provider#endpoints' because the source reflection class 'Endpoint' is associated to 'ExtManagementSystem' via :has_many.

   # ./spec/support/missing_factory_helper.rb:10:in `create'
   # ./spec/models/service_template_ansible_playbook_spec.rb:11:in `block (2 levels) in <top (required)>'
   # ./spec/models/service_template_ansible_playbook_spec.rb:7:in `block (2 levels) in <top (required)>'
   # ./spec/models/service_template_ansible_playbook_spec.rb:15:in `block (2 levels) in <top (required)>'
   # ./spec/models/service_template_ansible_playbook_spec.rb:40:in `block (2 levels) in <top (required)>'
   # ./spec/models/service_template_ansible_playbook_spec.rb:47:in `block (2 levels) in <top (required)>'
   # ./spec/models/service_template_ansible_playbook_spec.rb:82:in `block (3 levels) in <top (required)>'

Most likely do to a fix that I was unable to track down, but the following git log command is most likely to contain some of the commits with the fix:

$ git log --oneline -E --grep "has.*many.*through" 5-2-stable..6-0-stable

Links

• Part of the Rails 6 Upgrade: Support Rails 6.0 #19977

[NickLaMuro]

@miq-bot assign @jrafanie

Hopefully this works pre-rails6 so it is one less commit that needs to be included in the rails-6 branch. Currently this is on that branch, but I plan to remove it if it can be merged into master.

[NickLaMuro]

@miq-bot add_label rails6

[miq-bot]

Checked commit NickLaMuro@79c2826 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[agrare]

This seems to have caused manageiq-content to start failing: https://travis-ci.com/github/ManageIQ/manageiq-content/jobs/432734386#L1996-L2003

[NickLaMuro]

@agrare thanks for the heads up. I will take a look at it later today

[NickLaMuro]

So just a bit of a update:

Seems like doing:

FactoryBot.create(:embedded_ansible_automation_manager)

Creates 2 AutomationManager records... which is weird. Might be a seeding thing we did with the Provider class, so it might something where we should instead remove this factory and only create the Provider records. Will find more proof of this theory before I suggest what to do next.

[NickLaMuro]

Okay, yes, it looks like the AutomationManager is being created twice with this since the ensure_managers class is fired on a before_validation:

31a2f32

I think the solution for this is to deprecate creating :embedded_ansible_automation_manager records directly (change the provider :factory => ... line to a raise, and then change all callers of this to ensure that we create providers directly, and have them reference them through the provider directly (inverse of what I ended up doing in this commit).

I will try that out and see how that works.