Updates for Rails 6.0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails6, there is a deprecation warning with `.call` when working with
template handlers:
DEPRECATION WARNING: Single arity template handlers are deprecated.
Template handlers must now accept two parameters, the view object and the
source for the view object.
Change:
>> #<ActionView::Template::Handlers::RJS:0x00007f8ecf616cb8>.call(template)
To:
>> #<ActionView::Template::Handlers::RJS:0x00007f8ecf616cb8>.call(template, source)
This borrows from PR 138 in Hamlit that did the same thing:
- https://github.com/k0kubun/hamlit
- https://github.com/k0kubun/hamlit/blob/master/CHANGELOG.md#293---2019-04-09
|
@Fryguy please review. |
Fryguy
approved these changes
Nov 23, 2020
39 tasks
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Nov 24, 2020
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Nov 30, 2020
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Dec 1, 2020
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Dec 2, 2020
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Dec 3, 2020
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Dec 7, 2020
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Dec 10, 2020
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Jan 5, 2021
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
kbrock
pushed a commit
to kbrock/manageiq
that referenced
this pull request
Jan 27, 2021
Update to a version that includes the patch for Rails 6.0 ManageIQ/jquery-rjs#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #2
There isn't a need change the
alias_method_chainsince that seemed to have been addressed previously here:5ed5e95
Probably should be a major version update for this gem, but that can be up for discussion.
Links