Rails 6.0 #963
Merged
Rails 6.0 #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2020
NickLaMuro
force-pushed
the
rails-6
branch
2 times, most recently
from
7c1cb46
to
96699c4
Compare
Fixes the following deprecation warning in Rails 6: DEPRECATION WARNING: ActionDispatch::Http::ParameterFilter is deprecated and will be removed from Rails 6.1. Use ActiveSupport::ParameterFilter instead. (called from log_api_request at manageiq-api/app/controllers/api/base_controller/logger.rb:32)
.parent is deprecated in Rails 6, so use it's replacement .module_parent rails/rails@004fda3
A change seemed to happen regarding the result of the "Content-Disposition" header generation when upgrading to Rails 6.0. TODO: Will need to determine if this is fine being changed and where the change originated from.
Fixes the following deprecation warning: DEPRECATION WARNING: update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead) (called from block (3 levels) in <top (required)> at manageiq-api/spec/requests/vms_spec.rb:309)
|
Checked commits NickLaMuro/manageiq-api@90649d7~...5b0c540 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links