Build: Fix imported modules breaking ie11

[sirreal]

Fixes #12407

There were two issues:

---

1 - config module

Use local config module over node_modules/config:. #12403 added config dependency which is imported here:

jetpack/_inc/client/lib/analytics/index.js

Line 10 in 597bc7c

import config from 'config';

Due to module loading here:

jetpack/webpack.config.js

Line 24 in 597bc7c

modules: [ 'node_modules', path.resolve( __dirname, '_inc/client' ) ],

The new node_modules/config module is used over the intended one. That introduced new ie11 errors. Fixed here by importing the module with a relative path.

We might consider ordering the module resolution so that local modules have preference.

---

2 - debug module

The debug module is used directly in the application:

jetpack/_inc/client/lib/analytics/index.js

Line 4 in 597bc7c

import debugFactory from 'debug';

This dependency was not declared in package.json, so the whatever version happened to be available as a transitive dependency was used. v4 appears to be incompatible with ie11 and webpack/babel compilation and it is not used in Calypso, likely for this reason.

Fix by adding debug@3^ as a dependency.

We should enable an eslint lint rule like 'import/no-extraneous-dependencies': [ 'error', { packageDir: './' } ] to help prevent errors like this.

Testing instructions:

Try loading /wp-admin/admin.php?page=jetpack for a Jetpack site in IE11. Smoke test. The page should work properly without errors.

Proposed changelog entry for your changes:

• Fix an issue with in ie11 with the Jetpack Dashboard.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello sirreal! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28693-code before merging this PR. Thank you!

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 58cddc5

[simison]

I haven't tested in IE but code changes make sense.

debug@4 is tricky because some node_modules might start depending on it eventually.

[jeherve]

My IE11 VM won't start anymore, so I could only test in a different browser. I can confirm that the dashboard is displayed nicely and analytics still work.

I'll let someone else test in IE11.

[brbrr]

Dashboard works fine now!

There is quite a problem with "My Plan" page though, which I think is not related to this PR.

[jeherve]

There is quite a problem with "My Plan" page though, which I think is not related to this PR.

Logged in #12464