Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscriptions: display checkboxes above submit button. #12373

Merged
merged 1 commit into from
May 14, 2019
Merged

Subscriptions: display checkboxes above submit button. #12373

merged 1 commit into from
May 14, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 14, 2019

Changes proposed in this Pull Request:

In #9983, #11149, and #12273 we changed the way the subscription fields were hooked into the comment form.

This makes sure the checkboxes appear above the submit button instead of below:

Before

image

After

image

Testing instructions:

  • Disable the Comment Form module under Jetpack > Settings > Discussion
  • In Settings > Discussion, make sure the subscription checkboxes are set.
  • Visit a post when logged in, and when logged out.
  • The checkboxes should appear above the comment submit button in both cases.
  • Try to subscribe and make sure you still can.

Proposed changelog entry for your changes:

  • Subscriptions: display checkboxes above the comment submit button.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels May 14, 2019
@jeherve jeherve added this to the 7.4 milestone May 14, 2019
@jeherve jeherve requested a review from kraftbj May 14, 2019 21:06
@jeherve jeherve requested a review from a team as a code owner May 14, 2019 21:06
@jeherve jeherve self-assigned this May 14, 2019
@jeherve jeherve mentioned this pull request May 14, 2019
Merged
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against b48cfa5

kraftbj
kraftbj approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All better.

@kraftbj kraftbj merged commit 588d307 into master May 14, 2019
@kraftbj kraftbj deleted the fix/subscription-checkboxes-order branch May 14, 2019 21:25
@matticbot matticbot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 14, 2019
jeherve added a commit that referenced this pull request May 17, 2019
@jeherve
Changelog: add #12373
dd56809
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog: add #12373
8ec6457
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @jetpackbot @kraftbj @matticbot