-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About Page: remove submenu and add link to page in footer #12323
Conversation
Fixes #12315 You can now access the About Page from 4 different locations: - The Automattic link at the bottom of the Jetpack dashboard pages. - The About link at the bottom of the Jetpack dashboard pages. - The Automattic logo on any Jetpack non-react admin pages (e.g. Settings > Sharing) - The about link at the bottom of any Jetpack non-react admin pages (e.g. Settings > Sharing)
31e4a6e
to
d21645e
Compare
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 4, 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested, added code suggestion
- If your site is connected to wpcom or in dev mode, the About link will lead to the in-plugin about page. - If you are not connected yet, the About link will lead to Jetpack.com. See #12323 (comment)
Thanks for the feedback. This should be good for another review! |
🐑 |
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
We do not need to reorder the menu item anymore since we got rid of that menu item in #12323.
We do not need to reorder the menu item anymore since we got rid of that menu item in #12323.
Fixes #12315
Changes proposed in this Pull Request:
You can now access the About Page from 4 different locations:
Testing instructions:
Note:
Proposed changelog entry for your changes: