Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXN Tests: Better unexpected state handling in wpcom connection test #12328

Merged
merged 3 commits into from
May 20, 2019

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented May 9, 2019

Fixes #12325

Changes proposed in this Pull Request:

  • Handle cases where the Jetpack ID is non-standard and if WP.com 404s.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • No.

Testing instructions:

  • @eliorivero running it on his site.
  • Manually set your Jetpack ID option to a random string.
  • Run Site Health.

Proposed changelog entry for your changes:

  • Site Health: Improve error messaging.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended General [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 9, 2019
@kraftbj kraftbj added this to the 7.4 milestone May 9, 2019
@kraftbj kraftbj requested a review from eliorivero May 9, 2019 17:28
@kraftbj kraftbj requested a review from a team as a code owner May 9, 2019 17:28
@jetpackbot
Copy link

jetpackbot commented May 9, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 4802977

@jeherve
Copy link
Member

jeherve commented May 15, 2019

Leaving it for @eliorivero to give it a try as well!

@kraftbj kraftbj merged commit 307c70b into master May 20, 2019
@kraftbj kraftbj deleted the update/cxn-tests-wpcom-connection-test-404 branch May 20, 2019 21:00
@matticbot matticbot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 20, 2019
jeherve added a commit that referenced this pull request May 23, 2019
jeherve added a commit that referenced this pull request May 27, 2019
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Health: The WP.com endpoint can 404
6 participants