Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form: Update CSS stylesheet #12219

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

thomasguillot
Copy link
Contributor

Changes proposed in this Pull Request:

  • Display input elements full-width on small screen and when using the column block
  • On large screens, set input elements to 50% and texture to 100%
  • Replace px with em
  • Add style for Checkbox Multiple
  • Set font-weight of Radio/Checkbox labels to normal so we can differentiate with actual labels

Testing instructions:

  • Add a contact form to a page, make sure you use all available elements
  • Check the front-end, how does it look?
  • Resize the screen, is it full-width?
  • Add a contact form to a Column block, is it full-width when previewing the page?

Before:
1-before

After:
2-after

Proposed changelog entry for your changes:

  • Contact Form: Update CSS stylesheet

* Display input elements full-width on small screen and when using the column block
* On large screens, set input elements to 50% and texture to 100%
* Replace px with em
* Add style for Checkbox Multiple
* Set font-weight of Radio/Checkbox labels to normal so we can differentiate with actual labels
@thomasguillot thomasguillot added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Pri] Normal labels May 1, 2019
@thomasguillot thomasguillot requested a review from a team as a code owner May 1, 2019 07:49
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello thomasguillot! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27670-code before merging this PR. Thank you!

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against ac7dd44

@thomasguillot thomasguillot added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 1, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well for me. 👍

@jeherve jeherve added [Status] Needs Design Review Design has been added. Needs a review! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 1, 2019
@jeherve jeherve requested a review from a team May 1, 2019 13:24
@iamtakashi
Copy link
Contributor

Design wise 👍for me. This is a nice design upgrade, thank you, @thomasguillot !

@scottsweb
Copy link
Contributor

scottsweb commented May 1, 2019

Add a contact form to a page, make sure you use all available elements

👍

Check the front-end, how does it look?

Good, seems clean.

Resize the screen, is it full-width?

Yes

Add a contact form to a Column block, is it full-width when previewing the page?

Seems to be full width within the column:

Screenshot 2019-05-01 at 14 44 02

So, all good I think. 👍

@scottsweb scottsweb added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels May 1, 2019
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label May 1, 2019
@kraftbj kraftbj added this to the 7.4 milestone May 2, 2019
@kraftbj kraftbj merged commit dda1929 into master May 2, 2019
@kraftbj kraftbj deleted the update/contact-form-styles branch May 2, 2019 21:17
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 2, 2019
jeherve added a commit that referenced this pull request May 17, 2019
jeherve added a commit that referenced this pull request May 23, 2019
jeherve added a commit that referenced this pull request May 27, 2019
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants