Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memberships: Automatically select + min amount #12417

Merged
merged 3 commits into from
May 22, 2019
Merged

Memberships: Automatically select + min amount #12417

merged 3 commits into from
May 22, 2019

Conversation

artpi
Copy link
Contributor

@artpi artpi commented May 20, 2019 •
edited
Loading

@mtias has pointed out, that the current set up is a bit confusing.
After you add a new product, you have to CLICK it to display the button.

This change automatically preselects the new button, because you supposedly want to use the one you just created.

@rantoncuadrado has discovered that you can use the field stepper to input a negative value. I fixed that on the way

Testing instructions

  • Use memberships block
  • Add a new button, see it automatically selected.

@artpi artpi requested a review from a team as a code owner May 20, 2019 16:00
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello artpi! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28439-code before merging this PR. Thank you!

@artpi artpi added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 20, 2019
@artpi artpi self-assigned this May 20, 2019
@jetpackbot
Copy link

jetpackbot commented May 20, 2019 •
edited
Loading

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 01d7136

@matticbot
Copy link
Contributor

artpi, Your synced wpcom patch D28439-code has been updated.

@artpi artpi changed the title Memberships: Automatically select new button Memberships: Automatically select + min amount May 20, 2019
@artpi artpi requested a review from rantoncuadrado May 20, 2019 16:21
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Block] Payment Button aka Recurring Payments labels May 20, 2019
jeherve
jeherve previously approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change automatically preselects the new button, because you supposedly want to use the one you just created.

I like that, it makes things a lot faster. It also tests well on my end. This seems good to me, short of the comment Matias made above this should be good to go.

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 20, 2019
davemart-in
davemart-in previously approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea! LGTM!

@artpi artpi dismissed stale reviews from davemart-in and jeherve via 01d7136 May 21, 2019 04:13
@matticbot
Copy link
Contributor

artpi, Your synced wpcom patch D28439-code has been updated.

@artpi artpi added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels May 21, 2019
@jeherve jeherve removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 21, 2019
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label May 21, 2019
@jeherve jeherve added this to the 7.4 milestone May 21, 2019
@artpi artpi merged commit e4dcb10 into master May 22, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 22, 2019
@artpi artpi deleted the memberships/auto-select-product branch May 22, 2019 14:29
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog & Testing list: add #12416, #12417, #12418, and #12348
118adef
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtias mtias mtias left review comments

@jeherve jeherve jeherve approved these changes

@davemart-in davemart-in davemart-in left review comments

@eoigal eoigal Awaiting requested review from eoigal

@prettyboymp prettyboymp Awaiting requested review from prettyboymp

@rantoncuadrado rantoncuadrado Awaiting requested review from rantoncuadrado

Assignees

@artpi artpi

Labels
[Block] Payment Button aka Recurring Payments Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
6 participants
@artpi @matticbot @jetpackbot @jeherve @mtias @davemart-in