Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Icons SVG: switch to the presentation role #12339

Merged
merged 1 commit into from
May 13, 2019
Merged

Social Icons SVG: switch to the presentation role #12339

merged 1 commit into from
May 13, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 10, 2019

Fixes #12338

Changes proposed in this Pull Request:

Since the image is mostly decorative, and since we already hide it from screen readers with aria-hidden="true", let's also set it as a decorative element.

Testing instructions:

Proposed changelog entry for your changes:

  • Social Icons SVG: switch to the presentation role for better accessibility.

@jeherve
Social Icons SVG: switch to the presentation role
22ef0cb 
Fixes #12338

Since the image is mostly decorative, and since we already hide it from screen readers with `aria-hidden="true"`, let's also set it as a decorative element.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets [Focus] Accessibility Improving usability for all users (a11y) [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels May 10, 2019
@jeherve jeherve added this to the 7.4 milestone May 10, 2019
@jeherve jeherve requested a review from a team as a code owner May 10, 2019 16:59
@jeherve jeherve self-assigned this May 10, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D28064-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 14, 2019.
Scheduled code freeze: May 7, 2019

Generated by 🚫 dangerJS against 22ef0cb

zinigor
zinigor approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:til: about presentation, but it's logical to use presentation if we are already using hidden in the ARIA property.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 10, 2019
thomasguillot
thomasguillot approved these changes May 11, 2019
View reviewed changes
Copy link
Contributor

@thomasguillot thomasguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeherve jeherve merged commit a220a56 into master May 13, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 13, 2019
@jeherve jeherve deleted the fix/social-icon-svg-a11y branch May 13, 2019 07:52
jeherve added a commit that referenced this pull request May 17, 2019
@jeherve
changelog: add #12339
e1f254b
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
changelog: add #12339
d0cfdf6
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasguillot thomasguillot thomasguillot approved these changes

@zinigor zinigor zinigor approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets [Focus] Accessibility Improving usability for all users (a11y) [Pri] Normal Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

Social Media Widget Icons WAI-ARIA Role of "img" Fails Accessibility Checks
5 participants
@jeherve @matticbot @jetpackbot @thomasguillot @zinigor