Fix the macro definition _Thrd_success in thread #3775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
requested changes
Aug 2, 2023
There was a problem hiding this comment.
@jimwang118 Sorry to bother, but could you fix DCO?
You just need to sign-off your commit, i.e. git rebase HEAD~1 --signoff
|
git rebase HEAD~1 --signoff |
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
|
This modification will be applied in future versions of visual studio, and the old macro is still used in the current version.We need to wait for the release of the new version of STL to incorporate this PR. |
The changes should then depend on the STL version, using conditional |
7 tasks
|
@MiguelCompany ，The functions _Mtx_timedlock, _Mtx_init, and _Mtx_destroy are deleted in PR microsoft/STL#3912 of STL. Are there other functions that can replace these functions? |
* Refs #18395: Add regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #18395: Refactor XMLParser::parseLogConfig Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
* Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
* Refs #19315: Allow participant profiles with no rtps tag Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19315: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19315: Apply suggestions 2 Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
* Custom Payload pools test implementation (eProsima#3719) * Refs #19024: Public API implementation Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19024: Update versions.md Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Fix build issues Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Custom Payload pools test implementation Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #19023: Update test to use public API Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Please linters Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19023: Added delay between writing and checking payload request Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Include custom pools impl (eProsima#3740) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024: Modified custom payload pool and datasharing interaction Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19024. Correctly set payload owner on test pools. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
* Refs #19347: Fix encapsulation format in WLP. Improve WLP checks Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Correctly set CDR endianess for BE Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Uncrustify Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Fix doxygen Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Fix Windows warning Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Correct condition when setting the payload encapsulation Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Remove legacy typedef Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19347: Initialize uint32_t variable Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
* Refs #19358. Only account for WLP heartbeats and acknacks. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19358. Change test expectations. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19358. Rename counters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19358. Whitelist localhost to ensure only the two test participants communicate. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
…ype (eProsima#3786) * Refs #19359: Change ReturnCode when negotiating through type lookup service Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19359: Improve API reference Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19359: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> --------- Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
…into fix_STL_use
|
I think this PR would not be necessary after #3904 @jimwang118 could you check on your side? |
|
Duplicate of #3904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I was doing vcpkg testing msvc, the following error occurred on the fastrtps port.
E:\Jim\vcpkg\buildtrees\fastrtps\src\v2.11.1-d9ab4e5ea6\include\fastrtps/utils/TimedMutex.hpp(177): error C2065: '_Thrd_success': undeclared identifierAfter investigation, this is due to the modification of the
_Thrd_successmacro to_Thrd_result::_Successin the thread STL and the related PR is microsoft/STL#3897. Therefore, I will modify the macro in the code to_Thrd_result::_Success.