Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19023] Custom Payload pools test implementation #3719

Merged

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Jul 17, 2023

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso force-pushed the feature/custom-pools/test-impl branch from f0f370f to c8329a9 Compare July 17, 2023 15:30
@JesusPoderoso JesusPoderoso added this to the v2.12.0 milestone Jul 17, 2023
@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Jul 20, 2023
JesusPoderoso and others added 4 commits July 24, 2023 08:16
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 24, 2023

@richiprosima please test mac

1 similar comment
@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 25, 2023

@richiprosima please test mac

@jsan-rt
Copy link
Contributor Author

jsan-rt commented Jul 25, 2023

@JesusPoderoso changes LGTM.

@JesusPoderoso JesusPoderoso merged commit d0613be into feature/custom-pools/main Jul 26, 2023
6 checks passed
@JesusPoderoso JesusPoderoso deleted the feature/custom-pools/test-impl branch July 26, 2023 08:13
EduPonz pushed a commit that referenced this pull request Aug 3, 2023
* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
EduPonz pushed a commit that referenced this pull request Aug 3, 2023
* Custom Payload pools test implementation (#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
jimwang118 pushed a commit to jimwang118/Fast-DDS that referenced this pull request Aug 22, 2023
* Custom Payload pools test implementation (eProsima#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (eProsima#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>
juanlofer-eprosima pushed a commit that referenced this pull request Nov 10, 2023
* Custom Payload pools test implementation (#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
rsanchez15 pushed a commit that referenced this pull request Jan 15, 2024
* Custom Payload pools test implementation (#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
rsanchez15 pushed a commit that referenced this pull request Jan 16, 2024
* Custom Payload pools test implementation (#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Jan 17, 2024
* Custom pools on DDS layer feature (#3755)

* Custom Payload pools test implementation (#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>

* Add API to create writers and readers with a custom payload pool

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Use correct API in tests

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Fix Window warning about asio include

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Remove feature in forthcoming version file

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Add Asio include dir to datareader tests

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request Jan 18, 2024
* Custom pools on DDS layer feature (#3755)

* Custom Payload pools test implementation (#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>

* Add API to create writers and readers with a custom payload pool

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Use correct API in tests

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants