[19263 ] User configuration for SHM metatraffic #3753

MiguelCompany · 2023-07-27T06:49:30Z

Description

This is a rework of #3641.

In order to improve resilience when a participant dies unexpectedly, forcing discovery to use UDP by default.
The behavior can be configured using a new property fastdds.shm.enforce_metatraffic, which can take values none (default), unicast (default behavior before this PR), or all (would allow communication with a SHM only participant)

This PR changes the default behavior, but since it improves Fast DDS stability, and it has no ABI breaks, we will backport it to the supported branches.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: [19263] User configuration for SHM metatraffic Fast-DDS-docs#535
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

…butes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2023-07-27T07:33:57Z

@richiprosima Please test this

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2023-07-27T07:57:36Z

@richiprosima Please test this

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2023-07-27T08:58:03Z

@richiprosima Please test this

JesusPoderoso

If would be nice to have a set of communication tests that ckeck the three possibilities of this new feature (unicast, all, none [default])

src/cpp/rtps/network/NetworkFactory.cpp

test/unittest/rtps/network/NetworkFactoryTests.cpp

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2023-07-27T10:09:36Z

If would be nice to have a set of communication tests that ckeck the three possibilities of this new feature (unicast, all, none [default])

I will try to think of something. Perhaps some black-box testing would be possible.

src/cpp/rtps/network/NetworkFactory.cpp

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

JesusPoderoso · 2023-07-27T12:04:26Z

@richiprosima please test this

JesusPoderoso

LGTM with test

fujitatomoya

adding configuration parameter to fallback not to use shm transport for metatraffic, and default behavior change makes sense.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

…bReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany · 2023-07-31T13:40:39Z

@richiprosima Please test this

test/blackbox/common/DDSBlackboxTestsTransportSHMUDP.cpp

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

versions.md

EduPonz · 2023-08-02T10:52:49Z

@Mergifyio backport 2.11.x 2.10.x 2.6.x

mergify · 2023-08-02T10:52:59Z

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

#3776 [19263 ] User configuration for SHM metatraffic (backport #3753) has been created for branch 2.11.x
#3778 [19263 ] User configuration for SHM metatraffic (backport #3753) has been created for branch 2.10.x but encountered conflicts
#3777 [19263 ] User configuration for SHM metatraffic (backport #3753) has been created for branch 2.6.x but encountered conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Jesus is on vacation

* Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25631e6)

* Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25631e6) # Conflicts: # test/blackbox/common/DDSBlackboxTestsTransportSHMUDP.cpp # test/unittest/rtps/network/NetworkFactoryTests.cpp # versions.md

* Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25631e6) # Conflicts: # versions.md

* User configuration for SHM metatraffic (#3753) * Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25631e6) # Conflicts: # test/blackbox/common/DDSBlackboxTestsTransportSHMUDP.cpp # test/unittest/rtps/network/NetworkFactoryTests.cpp # versions.md * Refs #19263. Change new log to old macro. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Removed unrelated tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25631e6) Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* User configuration for SHM metatraffic (#3753) * Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25631e6) # Conflicts: # versions.md * Fix conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #18966. Forcing UDP for metatraffic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Allowing metatraffic depends on flags. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. NetworkFactory constructor receives RTPSParticipantAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Parsing property from participant attributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19255. Remove unused mp_ResourceSemaphore. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed NetworkFactoryTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed TCPv6Tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Fixed link errors on unit tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Additional suggestions from code review. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added possitive test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Added negative test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Configuration for max_multicast_locators_number on PubSubReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Enable multicast discovery on new test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Add feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #19263. Apply suggestion. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: jimwang118 <wangzhijie05@beyondsoft.com>

MiguelCompany added 5 commits July 27, 2023 08:39

Refs #18966. Forcing UDP for metatraffic.

bef5e29

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19255. Allowing metatraffic depends on flags.

0400e26

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19255. NetworkFactory constructor receives RTPSParticipantAttri…

4d553dc

…butes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19255. Parsing property from participant attributes.

432a4be

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19255. Remove unused mp_ResourceSemaphore.

c900486

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany added the doc-pending Issue or PR which is pending to be documented label Jul 27, 2023

MiguelCompany added this to the v2.12.0 milestone Jul 27, 2023

MiguelCompany changed the title ~~User configuration for SHM metatraffic~~ [19263 ] User configuration for SHM metatraffic Jul 27, 2023

Refs #19263. Fixed NetworkFactoryTests.

89da725

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19263. Fixed TCPv6Tests.

1964fff

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19263. Fixed link errors on unit tests.

1417a6e

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

JesusPoderoso previously requested changes Jul 27, 2023

View reviewed changes

src/cpp/rtps/network/NetworkFactory.cpp Outdated Show resolved Hide resolved

src/cpp/rtps/network/NetworkFactory.cpp Show resolved Hide resolved

test/unittest/rtps/network/NetworkFactoryTests.cpp Outdated Show resolved Hide resolved

Refs #19263. Apply suggestions from code review.

a78820a

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

JesusPoderoso reviewed Jul 27, 2023

View reviewed changes

src/cpp/rtps/network/NetworkFactory.cpp Outdated Show resolved Hide resolved

Refs #19263. Additional suggestions from code review.

f6bef17

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

JesusPoderoso reviewed Jul 27, 2023

View reviewed changes

This was referenced Jul 27, 2023

[19267] Improve SHM resilience to crashing participants #3759

Merged

Cannot discover the endpoint after multiple nodes created and exited ros2/rmw_fastrtps#699

Closed

fujitatomoya previously approved these changes Jul 28, 2023

View reviewed changes

fujitatomoya mentioned this pull request Jul 28, 2023

Communication fails after starting and stopping nodes ros2/ros2#1458

Closed

MiguelCompany added 5 commits July 31, 2023 10:02

Refs #19263. Added possitive test.

74737a9

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19263. Added negative test.

9ccb538

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19263. Configuration for avoid_builtin_multicast on PubSubWriter.

b204f5d

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19263. Configuration for avoid_builtin_multicast on PubSubReader.

f1526bf

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19263. Configuration for max_multicast_locators_number on PubSu…

07a5493

…bReader/PubSubWriter. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Refs #19263. Enable multicast discovery on new test.

773a210

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany dismissed fujitatomoya’s stale review via 773a210 July 31, 2023 13:31

jsan-rt suggested changes Jul 31, 2023

View reviewed changes

test/blackbox/common/DDSBlackboxTestsTransportSHMUDP.cpp Outdated Show resolved Hide resolved

test/blackbox/common/DDSBlackboxTestsTransportSHMUDP.cpp Show resolved Hide resolved

Refs #19263. Apply suggestions.

57a0c2b

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

jsan-rt approved these changes Jul 31, 2023

View reviewed changes

iuhilnehc-ynos mentioned this pull request Aug 1, 2023

Nodes missing from ros2 node list after relaunch ros2/ros2cli#582

Closed

Refs #19263. Add feature to versions.md.

8a74e20

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany mentioned this pull request Aug 2, 2023

[19263] User configuration for SHM metatraffic eProsima/Fast-DDS-docs#535

Merged

MiguelCompany removed the doc-pending Issue or PR which is pending to be documented label Aug 2, 2023

EduPonz suggested changes Aug 2, 2023

View reviewed changes

versions.md Show resolved Hide resolved

Refs #19263. Apply suggestion.

932a0dc

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

MiguelCompany added the skip-ci Automatically pass CI label Aug 2, 2023

EduPonz approved these changes Aug 2, 2023

View reviewed changes

MiguelCompany merged commit 25631e6 into master Aug 2, 2023
7 checks passed

MiguelCompany deleted the bugfix/shm/edp_via_udp branch August 2, 2023 11:13

mergify bot mentioned this pull request Aug 2, 2023

[19263 ] User configuration for SHM metatraffic (backport #3753) #3776

Merged

mergify bot mentioned this pull request Aug 2, 2023

[19263 ] User configuration for SHM metatraffic (backport #3753) #3777

Merged

mergify bot mentioned this pull request Aug 2, 2023

[19263 ] User configuration for SHM metatraffic (backport #3753) #3778

Merged

fujitatomoya mentioned this pull request Dec 21, 2023

Add example deployment with Data Sharing via LoanedMessage fujitatomoya/ros_k8s#31

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[19263 ] User configuration for SHM metatraffic #3753

[19263 ] User configuration for SHM metatraffic #3753

MiguelCompany commented Jul 27, 2023 •

edited by EduPonz

Loading

MiguelCompany commented Jul 27, 2023

MiguelCompany commented Jul 27, 2023

MiguelCompany commented Jul 27, 2023

JesusPoderoso left a comment •

edited

Loading

MiguelCompany commented Jul 27, 2023 •

edited

Loading

JesusPoderoso commented Jul 27, 2023

JesusPoderoso left a comment

fujitatomoya left a comment

MiguelCompany commented Jul 31, 2023

EduPonz commented Aug 2, 2023

mergify bot commented Aug 2, 2023 •

edited

Loading

[19263 ] User configuration for SHM metatraffic #3753

[19263 ] User configuration for SHM metatraffic #3753

Conversation

MiguelCompany commented Jul 27, 2023 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

MiguelCompany commented Jul 27, 2023

MiguelCompany commented Jul 27, 2023

MiguelCompany commented Jul 27, 2023

JesusPoderoso left a comment • edited Loading

Choose a reason for hiding this comment

MiguelCompany commented Jul 27, 2023 • edited Loading

JesusPoderoso commented Jul 27, 2023

JesusPoderoso left a comment

Choose a reason for hiding this comment

fujitatomoya left a comment

Choose a reason for hiding this comment

MiguelCompany commented Jul 31, 2023

EduPonz commented Aug 2, 2023

mergify bot commented Aug 2, 2023 • edited Loading

✅ Backports have been created

MiguelCompany commented Jul 27, 2023 •

edited by EduPonz

Loading

JesusPoderoso left a comment •

edited

Loading

MiguelCompany commented Jul 27, 2023 •

edited

Loading

mergify bot commented Aug 2, 2023 •

edited

Loading