[19642] Use STL implementation of Timed/RecursiveTimedMutex when MSVC >= 19.36 #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SVC >= 19.36 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
added
needs-review
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
|
@richiprosima please test mac |
|
@richiprosima Please test this |
1 task
|
I am the maintainer of |
|
@richiprosima please test mac |
1 similar comment
|
@richiprosima please test mac |
|
@Mergifyio backport 2.11.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
#3904) * Refs #19642: Use STL implementation of Timed/RecursiveTimedMutex in MSVC >= 19.36 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19642: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e2137cb)
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
#3904) * Refs #19642: Use STL implementation of Timed/RecursiveTimedMutex in MSVC >= 19.36 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19642: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e2137cb)
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
#3904) * Refs #19642: Use STL implementation of Timed/RecursiveTimedMutex in MSVC >= 19.36 Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #19642: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit e2137cb)
7 tasks
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes to the the STL implementation the Timed/RecursiveTimedMutex in MSVC >= 19.36.
Note: Tested compilation against 19.37.32824.0
@Mergifyio backport 2.11.x 2.10.x 2.6.x
Fixes #3783
Fixes #3829
Contributor Checklist
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Reviewer Checklist