-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update actions/setup-node digest to 1e60f62 - abandoned #1990
base: main
Are you sure you want to change the base?
Conversation
* Document domain model Related #1830
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: switch to esbuild * chore: change module imports to relative so esbuild can find them
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Add Codecov bundler plugin and upload token
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1842) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: modify cert, key, registry to download * chore(test): write test for web methods * chore(deps): update dependencies * chore(test): add test for generateShardList * Add .env.example file and update docker-compose.yml***
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: pin images to version * chore: remove sha
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [identify](https://github.com/pre-commit/identify) | `==2.5.36` -> `==2.6.0` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/identify/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/identify/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/identify/2.5.36/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/identify/2.5.36/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pre-commit/identify (identify)</summary> ### [`v2.6.0`](https://github.com/pre-commit/identify/compare/v2.5.36...v2.6.0) [Compare Source](https://github.com/pre-commit/identify/compare/v2.5.36...v2.6.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sentry-sdk](https://github.com/getsentry/sentry-python) ([changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)) | `==2.7.1` -> `==2.8.0` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/sentry-sdk/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/sentry-sdk/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/sentry-sdk/2.7.1/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/sentry-sdk/2.7.1/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>getsentry/sentry-python (sentry-sdk)</summary> ### [`v2.8.0`](https://github.com/getsentry/sentry-python/blob/HEAD/CHANGELOG.md#280) [Compare Source](https://github.com/getsentry/sentry-python/compare/2.7.1...2.8.0) ##### Various fixes & improvements - `profiler_id` uses underscore ([#​3249](https://github.com/getsentry/sentry-python/issues/3249)) by [@​Zylphrex](https://github.com/Zylphrex) - Don't send full env to subprocess ([#​3251](https://github.com/getsentry/sentry-python/issues/3251)) by [@​kmichel-aiven](https://github.com/kmichel-aiven) - Stop using `Hub` in `HttpTransport` ([#​3247](https://github.com/getsentry/sentry-python/issues/3247)) by [@​szokeasaurusrex](https://github.com/szokeasaurusrex) - Remove `ipdb` from test requirements ([#​3237](https://github.com/getsentry/sentry-python/issues/3237)) by [@​rominf](https://github.com/rominf) - Avoid propagation of empty baggage ([#​2968](https://github.com/getsentry/sentry-python/issues/2968)) by [@​hartungstenio](https://github.com/hartungstenio) - Add entry point for `SentryPropagator` ([#​3086](https://github.com/getsentry/sentry-python/issues/3086)) by [@​mender](https://github.com/mender) - Bump checkouts/data-schemas from `8c13457` to `88273a9` ([#​3225](https://github.com/getsentry/sentry-python/issues/3225)) by [@​dependabot](https://github.com/dependabot) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
some formatting changes occured on unrelated files
…paths and add ignore rule for __generated__ directory
some formatting changes occured on unrelated files
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `22.4.0` -> `22.4.1` | --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v22.4.1`](https://github.com/nodejs/node/compare/v22.1.0...v22.4.1) [Compare Source](https://github.com/nodejs/node/compare/v22.4.0...v22.4.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Here's the code health analysis summary for commits Analysis Summary
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes involve updating the version of the Node.js setup action used in two GitHub Action workflows. While this is generally a good practice to keep dependencies up-to-date, it's important to ensure that the updated action version remains compatible with the existing workflow, and doesn't introduce breaking changes. Also, make sure to test the action workflows after updating to gauge the potential impact before merging.
@@ -20,7 +20,7 @@ jobs: | |||
with: | |||
fetch-depth: 0 | |||
- name: Use Node.js 22.x | |||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4 | |||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have updated the setup-node action to a different commit hash. Please ensure that this new commit hash is compatible with your workflow and doesn't introduce any breaks or issues. I would also recommend adding a label indicating the version of the setup-node action that the new commit hash represents for better readability.
@@ -23,7 +23,7 @@ jobs: | |||
with: | |||
fetch-depth: 0 | |||
- name: Setup Node.js | |||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4 | |||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the change in the node.yml file, the setup-node action has been updated here as well. Similar to the previous comment, ensure its compatibility with the release workflow and consider adding an indicative version label for clearer understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes involve updating of the version of Node.js being used in the Github-Actions workflow yml files. No serious issues were discovered in this code review. However, some further improvements can be made.
@@ -20,7 +20,7 @@ jobs: | |||
with: | |||
fetch-depth: 0 | |||
- name: Use Node.js 22.x | |||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4 | |||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the version of setup-node
action, please make sure the new version (1e60f620b9541d16bece96c5465dc8ee9832be0b) doesn't have any breaking changes or bugs that could affect your workflow. It is always recommended to test the changes either locally or on a separate branch before merging the changes into your main branch.
@@ -23,7 +23,7 @@ jobs: | |||
with: | |||
fetch-depth: 0 | |||
- name: Setup Node.js | |||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4 | |||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain consistency across workflows, ensure the version of Node.js being used is the same in all workflows. If the Node version needs to be changed, it should be updated in all relevant places to avoid discrepancies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in the commit mostly pertain to the upgrade of the node setup action in two GitHub workflows. Although the 'v4' comment suggests version 4 of the action is being used, the commit hash has been changed which might change the action's version or behavior. It is recommended to either pin to a specific version tag or use a version range for stability if this action obeys SemVer rules. Use caution with using a commit hash directly as this could lead to unpredictable results.
@@ -20,7 +20,7 @@ jobs: | |||
with: | |||
fetch-depth: 0 | |||
- name: Use Node.js 22.x | |||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4 | |||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'setup-node' GitHub Action hash has been changed. Make sure that the new change is compatible with your project's needs and replace the 'v4' comment with the corresponding version of 'setup-node' action used as per the new hash. Consider pinning to a released version/tag if possible for stability, unless there are specific reasons to point directly to a commit hash.
@@ -23,7 +23,7 @@ jobs: | |||
with: | |||
fetch-depth: 0 | |||
- name: Setup Node.js | |||
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4 | |||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too the 'setup-node' GitHub Action hash has been updated. Ensure its compatibility with the project dependencies and put the correct version of 'setup-node' action in the comment. It is recommended to use a version range or a specific version tag instead of a commit hash if the action follows Semantic Versioning.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
=======================================
Coverage 10.51% 10.51%
=======================================
Files 97 97
Lines 8503 8503
Branches 112 108 -4
=======================================
Hits 894 894
Misses 7609 7609
☔ View full report in Codecov by Sentry. |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
60edb5d
->1e60f62
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.