Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency slonik to v37.4.0 #1845

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 23, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
slonik 37.3.1 -> 37.4.0 age adoption passing confidence

Release Notes

gajus/slonik (slonik)

v37.4.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled because a matching PR was automerged previously.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

coderabbitai bot commented Mar 23, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

deepsource-io bot commented Mar 23, 2024

Here's the code health analysis summary for commits 5b3e17a..274ed91. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

socket-security bot commented Mar 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/slonik@37.4.0 Transitive: environment, filesystem, network +39 1.49 MB gajus

🚮 Removed packages: npm/slonik@37.3.1

View full report↗︎

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.62%. Comparing base (5b3e17a) to head (274ed91).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1845   +/-   ##
=======================================
  Coverage   35.62%   35.62%           
=======================================
  Files         127      127           
  Lines       12063    12063           
  Branches      219      137   -82     
=======================================
  Hits         4298     4298           
  Misses       7765     7765           
Flag Coverage Δ
core 100.00% <ø> (ø)
database 14.00% <ø> (ø)
gateway 37.60% <ø> (ø)
lobby 26.48% <ø> (ø)
login 21.30% <ø> (ø)
patch 53.09% <ø> (ø)
persona 21.94% <ø> (ø)
shard 56.67% <ø> (ø)
transactions 45.32% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/slonik-37.x-lockfile branch from 05ee70c to 1fb1a11 Compare March 23, 2024 07:19
Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff indicates version upgrades for the 'slonik' and '@types/pg' packages in pnpm-lock.yaml file. Ensure these version upgrades do not bring breaking changes to your project. Always have tests in place to catch unexpected issues that may arise due to version changes.

@@ -37,7 +37,7 @@ importers:
version: 5.0.3
slonik:
specifier: '37'
version: 37.3.1(zod@3.22.4)
version: 37.4.0(zod@3.22.4)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here 'slonik' package has been upgraded from version 37.3.1 to 37.4.0. Make sure the changes in this version do not break the current functionality of the project.

@@ -53,7 +53,7 @@ importers:
version: 7.108.0
'@slonik/migrator':
specifier: 0.12.0
version: 0.12.0(@types/node@20.11.30)(slonik@37.3.1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here '@slonik/migrator' package also reflects the version change of 'slonik' from 37.3.1 to 37.4.0. Please ensure that this does not conflict with '@slonik/migrator' functionality.

@@ -104,7 +104,7 @@ importers:
version: 7.108.0
slonik:
specifier: ^37.2.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another 'slonik' package upgrade instance. Verify that all instances of 'slonik' package in your project are updated to maintain consistency.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
resolution: {integrity: sha512-2kAXCO/iW9/VOYlfl8Jza4fQpi5Q8+JUyB38YFUxPiWNc+6o41GGND2aIpnyr6EPFNRXdg5x+Fu8+SMyMvMXpQ==}
peerDependencies:
slonik: 27 - 29
dependencies:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'slonik' package update is reflected here as well. Make sure this doesn't affect the dependencies and transitive dependencies linked with it.

@@ -1274,8 +1274,8 @@ packages:
dependencies:
undici-types: 5.26.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here '@types/pg' package has been upgraded from version 8.11.2 to 8.11.4. Check if this version change introduces new features or bug fixes which may be beneficial or disruptive to your project.

@@ -3824,13 +3824,13 @@ packages:
engines: {node: '>=14'}
dev: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, the 'slonik' package has been updated here which reaffirms the need to ensure the update's compatibility with various parts of the project.

/slonik@37.3.1(zod@3.22.4):
resolution: {integrity: sha512-vidC0OleHqIrFt5gGWgwy4CUhE+dSo71/661g2MyQFNpT/ZyiBZ1BscGK8gLlw4K8xYTo4SL+POBBLp+X5wYsg==}
/slonik@37.4.0(zod@3.22.4):
resolution: {integrity: sha512-W9GPnc4M5+JLvrl4aMx2qkpIQrHLo6vAmCc2UeTD5Szl2uBA2ChZo3njdygK1511wrlSSDnOySY+jlLNAfpIvA==}
engines: {node: '>=18'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '@types/pg' version update is seen here again. Ensure that all package instances are successfully updated.

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this Git diff primarily update versions for multiple packages including 'slonik' and '@types/pg'. However, a potential issue is found with the peerDependencies of '@slonik/migrator'. It specifies its 'slonik' peer dependency taking versions 27 to 29 while the slonik package itself is being updated to version 37.4.0 which can cause version conflict problems.

@@ -37,7 +37,7 @@ importers:
version: 5.0.3
slonik:
specifier: '37'
version: 37.3.1(zod@3.22.4)
version: 37.4.0(zod@3.22.4)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'slonik' package is being updated from version 37.3.1 to 37.4.0. Make sure all usages are tested and any breaking changes in the new version are accounted for.

@@ -53,7 +53,7 @@ importers:
version: 7.108.0
'@slonik/migrator':
specifier: 0.12.0
version: 0.12.0(@types/node@20.11.30)(slonik@37.3.1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slonik/migrator is depending on 'slonik' version 37.4.0. The dependent libraries need to be thoroughly tested with this updated version.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line defines the peerDependency for '@slonik/migrator' to accept 'slonik' versions from 27 to 29. This range doesn't include the new version of 'slonik' (37.4.0) being used, which could potentially lead to dependency errors.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
resolution: {integrity: sha512-2kAXCO/iW9/VOYlfl8Jza4fQpi5Q8+JUyB38YFUxPiWNc+6o41GGND2aIpnyr6EPFNRXdg5x+Fu8+SMyMvMXpQ==}
peerDependencies:
slonik: 27 - 29
dependencies:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line shows '@slonik/migrator' directly depending on 'slonik' version 37.4.0, which doesn't align with its defined peerDependencies versions of 27 to 29.

@@ -3824,13 +3824,13 @@ packages:
engines: {node: '>=14'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'slonik' package is being updated from version 37.3.1 to 37.4.0. As this package is widely used across the project (as per lines 10, 28, 44), ensure all components depending on it are tested.

@@ -1274,8 +1274,8 @@ packages:
dependencies:
undici-types: 5.26.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The '@types/pg' package is being updated from version 8.11.2 to 8.11.4. Ensure all areas of code leveraging this package are tested with this new version.

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is mainly about version upgrades of different software dependencies. Slonik has been upgraded from version 37.3.1 to 37.4.0 in multiple parts of the pnpm-lock.yaml file. '@types/pg' package has been upgraded from 8.11.2 to 8.11.4. However, there seems to be inconsistency about the peer dependencies for 'slonik' which could be an error.

@@ -37,7 +37,7 @@ importers:
version: 5.0.3
slonik:
specifier: '37'
version: 37.3.1(zod@3.22.4)
version: 37.4.0(zod@3.22.4)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of 'slonik' has been upgraded to 37.4.0 from 37.3.1. Make sure the higher version doesn't break any functionalities.

@@ -53,7 +53,7 @@ importers:
version: 7.108.0
'@slonik/migrator':
specifier: 0.12.0
version: 0.12.0(@types/node@20.11.30)(slonik@37.3.1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of 'slonik' for '@slonik/migrator' has been upgraded to 37.4.0 from 37.3.1. Check whether the new version of 'slonik' is compatible with '@slonik/migrator'.

@@ -104,7 +104,7 @@ importers:
version: 7.108.0
slonik:
specifier: ^37.2.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary version of the 'slonik' has also been upgraded to 37.4.0 from 37.3.1. All instances of 'slonik' are now referring to 37.4.0.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version updates for '@slonik/migrator' reflecting the upgraded version of 'slonik'. Ensure the changes do not introduce dependencies issues.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
resolution: {integrity: sha512-2kAXCO/iW9/VOYlfl8Jza4fQpi5Q8+JUyB38YFUxPiWNc+6o41GGND2aIpnyr6EPFNRXdg5x+Fu8+SMyMvMXpQ==}
peerDependencies:
slonik: 27 - 29
dependencies:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update in the dependencies for '@slonik/migrator', 'slonik' appears to be updated here as well.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peerDependencies for 'slonik' seems to be mentioning version 27-29, but the actual use of 'slonik' is of version 37.4.0. This inconsistency should be corrected.

@@ -1274,8 +1274,8 @@ packages:
dependencies:
undici-types: 5.26.5

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'@types/pg' version is updated to 8.11.4 from 8.11.2. Similar to the other updates, please ensure that this upgrade does not cause any issues.

@@ -3824,13 +3824,13 @@ packages:
engines: {node: '>=14'}
dev: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'slonik' version update is reflected in the resolution as well. Please cross-check the integrity hash to ensure high security.

/slonik@37.3.1(zod@3.22.4):
resolution: {integrity: sha512-vidC0OleHqIrFt5gGWgwy4CUhE+dSo71/661g2MyQFNpT/ZyiBZ1BscGK8gLlw4K8xYTo4SL+POBBLp+X5wYsg==}
/slonik@37.4.0(zod@3.22.4):
resolution: {integrity: sha512-W9GPnc4M5+JLvrl4aMx2qkpIQrHLo6vAmCc2UeTD5Szl2uBA2ChZo3njdygK1511wrlSSDnOySY+jlLNAfpIvA==}
engines: {node: '>=18'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'slonik' upgrade seems to affect the dependency to '@types/pg' as well, upgrading it to 8.11.4 from 8.11.2. Make sure new version of '@types/pg' works correctly with 'slonik'.

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are primarily updating the versions of packages namely '@slonik/migrator', 'slonik', and '@types/pg'. Although these upgrades are good for getting the latest features and bug fixes, we should ensure that the updated versions don't introduce any breaking changes or have any known issues that could affect our application.

@@ -37,7 +37,7 @@ importers:
version: 5.0.3
slonik:
specifier: '37'
version: 37.3.1(zod@3.22.4)
version: 37.4.0(zod@3.22.4)
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of the slonik package has been upgraded from 37.3.1 to 37.4.0. This is generally fine, but it would be necessary to ensure that this new version works correctly with any code that depends on this package. It's highly recommended to have unit tests that verify said behavior.

@@ -53,7 +53,7 @@ importers:
version: 7.108.0
'@slonik/migrator':
specifier: 0.12.0
version: 0.12.0(@types/node@20.11.30)(slonik@37.3.1)
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'@slonik/migrator' version is updated to be used with 'slonik' version 37.4.0. Please make sure all dependencies of '@slonik/migrator' are compatible with updated 'slonik' version.

@@ -104,7 +104,7 @@ importers:
version: 7.108.0
slonik:
specifier: ^37.2.0
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of 'slonik' has again been updated from 37.3.1 to 37.4.0 in another section of the code. Ensure the consistency of package version across your whole project.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'@slonik/migrator' version is changed along with 'slonik' version change. It’s good that dependencies are kept in sync but detailed testing is necessary before deployment.

@@ -1245,13 +1245,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
resolution: {integrity: sha512-2kAXCO/iW9/VOYlfl8Jza4fQpi5Q8+JUyB38YFUxPiWNc+6o41GGND2aIpnyr6EPFNRXdg5x+Fu8+SMyMvMXpQ==}
peerDependencies:
slonik: 27 - 29
dependencies:
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in 'slonik' version. It’s always better to keep all instances of packages updated to the same version to avoid inconsistencies.

@@ -1274,8 +1274,8 @@ packages:
dependencies:
undici-types: 5.26.5
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'@types/pg' version is updated from 8.11.2 to 8.11.4. It's important to check the changelogs for any potential breaking changes.

@@ -3824,13 +3824,13 @@ packages:
engines: {node: '>=14'}
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'slonik' package version upgrade is reflected here again. This version change should be cross-checked across all components to ensure that no breaking changes are introduced.

/slonik@37.3.1(zod@3.22.4):
resolution: {integrity: sha512-vidC0OleHqIrFt5gGWgwy4CUhE+dSo71/661g2MyQFNpT/ZyiBZ1BscGK8gLlw4K8xYTo4SL+POBBLp+X5wYsg==}
/slonik@37.4.0(zod@3.22.4):
resolution: {integrity: sha512-W9GPnc4M5+JLvrl4aMx2qkpIQrHLo6vAmCc2UeTD5Szl2uBA2ChZo3njdygK1511wrlSSDnOySY+jlLNAfpIvA==}
engines: {node: '>=18'}
Copy link

@codecov codecov bot Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating '@types/pg' to 8.11.4. This should bring it in line with the other updates, but again, make sure your code is compatible with these new versions.

@renovate renovate bot force-pushed the renovate/slonik-37.x-lockfile branch from 1fb1a11 to 274ed91 Compare March 23, 2024 12:49
Copy link

codecov bot commented Mar 23, 2024

Bundle Report

Bundle size has no change ✅

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodecovAI submitted a new review for 274ed91

@@ -1287,8 +1287,8 @@ packages:
dependencies:
undici-types: 5.26.5

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version '@types/pg' has been updated here as well. Make sure the changes correlate with the all other changes and the updated version of 'pg' is compatible with '@types/pg'.

@@ -3826,13 +3826,13 @@ packages:
engines: {node: '>=14'}
dev: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated version of 'slonik' is installed here as well. Consistency is maintained.

@@ -1258,13 +1258,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the versions of 'slonik' in peerDependencies of '@slonik/migrator'. The versions are way behind the current and the upgraded versions.

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodecovAI submitted a new review for 274ed91

@@ -1287,8 +1287,8 @@ packages:
dependencies:
undici-types: 5.26.5

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of the @types/pg package has been upgraded from 8.11.2 to 8.11.4. As with the previous comment, it's necessary to verify that the changes between these versions do not affect the way your software operates. A proper set of unit tests could thoroughly validate this.

@@ -1258,13 +1258,13 @@ packages:
resolution: {integrity: sha512-+Fj43pSMwJs4KRrH/938Uf+uAELIgVBmQzg/q1YG10djyfA3TnrU8N8XzqCh/okZdszqBQTZf96idMfE5lnwTA==}
dev: true

/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.3.1):
/@slonik/migrator@0.12.0(@types/node@20.11.30)(slonik@37.4.0):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this line, it specifies that the version of slonik is expected to be between 27 and 29 by the @slonik/migrator package. However, as seen in the recent changes, the slonik version has become 37.4.0, which doesn't satisfy this condition. This conflict can potentially cause issues at runtime and it would be better to clarify the need for the slonik version requirements for @slonik/migrator or to have the version updated to match the expectations.

@drazisil drazisil merged commit 396af2e into main Mar 23, 2024
14 checks passed
@drazisil drazisil deleted the renovate/slonik-37.x-lockfile branch March 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant