Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to esbuild #1840

Merged
merged 5 commits into from
Mar 23, 2024
Merged

chore: switch to esbuild #1840

merged 5 commits into from
Mar 23, 2024

Conversation

drazisil
Copy link
Collaborator

No description provided.

Copy link

coderabbitai bot commented Mar 22, 2024

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

193 files out of 296 files are above the max files limit of 100.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

deepsource-io bot commented Mar 22, 2024

Here's the code health analysis summary for commits 4adc91f..32e99df. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 23 occurences introduced
🎯 33 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 6.78405% with 1800 lines in your changes are missing coverage. Please review.

Project coverage is 35.62%. Comparing base (4adc91f) to head (32e99df).

✅ All tests successful. No failed tests found ☺️

Files Patch % Lines
packages/transactions/src/LobbyMessage.d.ts 0.00% 128 Missing ⚠️
packages/gateway/src/GatewayServer.d.ts 0.00% 121 Missing ⚠️
packages/persona/src/PersonaMapsMessage.d.ts 0.00% 100 Missing ⚠️
packages/gateway/src/index.d.ts 0.00% 86 Missing ⚠️
packages/patch/src/PatchServer.d.ts 0.00% 76 Missing ⚠️
packages/lobby/src/handlers/encryptedCommand.d.ts 0.00% 71 Missing ⚠️
packages/transactions/src/GenericReplyMessage.d.ts 0.00% 67 Missing ⚠️
packages/persona/src/internal.d.ts 0.00% 64 Missing ⚠️
packages/login/src/NPSUserStatus.d.ts 0.00% 62 Missing ⚠️
packages/login/src/internal.d.ts 0.00% 53 Missing ⚠️
... and 47 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
- Coverage   41.76%   35.62%   -6.15%     
==========================================
  Files          83      127      +44     
  Lines       10273    12063    +1790     
  Branches      160      140      -20     
==========================================
+ Hits         4291     4298       +7     
- Misses       5982     7765    +1783     
Flag Coverage Δ
core 100.00% <ø> (ø)
database 14.00% <23.80%> (-0.03%) ⬇️
gateway 37.60% <4.87%> (-9.49%) ⬇️
lobby 26.48% <3.78%> (-6.39%) ⬇️
login 21.30% <14.58%> (-1.98%) ⬇️
patch 53.09% <1.29%> (-34.20%) ⬇️
persona 21.94% <2.94%> (-6.78%) ⬇️
shard 56.67% <4.34%> (-4.65%) ⬇️
transactions 45.32% <8.22%> (-7.42%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Mar 22, 2024

Copy link

socket-security bot commented Mar 22, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@babel/code-frame@7.24.2, npm/@babel/compat-data@7.24.1, npm/@babel/core@7.24.3, npm/@babel/generator@7.24.1, npm/@babel/helper-compilation-targets@7.23.6, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-hoist-variables@7.22.5, npm/@babel/helper-module-imports@7.24.3, npm/@babel/helper-module-transforms@7.23.3, npm/@babel/helper-simple-access@7.22.5, npm/@babel/helper-split-export-declaration@7.22.6, npm/@babel/helper-validator-option@7.23.5, npm/@babel/helpers@7.24.1, npm/@babel/highlight@7.24.2, npm/@babel/parser@7.24.1, npm/@babel/template@7.24.0, npm/@babel/traverse@7.24.1, npm/@esbuild/aix-ppc64@0.20.2, npm/@esbuild/android-arm64@0.20.2, npm/@esbuild/android-arm@0.20.2, npm/@esbuild/android-x64@0.20.2, npm/@esbuild/darwin-arm64@0.20.2, npm/@esbuild/darwin-x64@0.20.2, npm/@esbuild/freebsd-arm64@0.20.2, npm/@esbuild/freebsd-x64@0.20.2, npm/@esbuild/linux-arm64@0.20.2, npm/@esbuild/linux-arm@0.20.2, npm/@esbuild/linux-ia32@0.20.2, npm/@esbuild/linux-loong64@0.20.2, npm/@esbuild/linux-mips64el@0.20.2, npm/@esbuild/linux-ppc64@0.20.2, npm/@esbuild/linux-riscv64@0.20.2, npm/@esbuild/linux-s390x@0.20.2, npm/@esbuild/linux-x64@0.20.2, npm/@esbuild/netbsd-x64@0.20.2, npm/@esbuild/openbsd-x64@0.20.2, npm/@esbuild/sunos-x64@0.20.2, npm/@esbuild/win32-arm64@0.20.2, npm/@esbuild/win32-ia32@0.20.2, npm/@esbuild/win32-x64@0.20.2, npm/@sentry-internal/tracing@7.107.0, npm/@sentry/babel-plugin-component-annotate@2.16.0, npm/@sentry/bundler-plugin-core@2.16.0, npm/@sentry/cli-linux-arm64@2.30.2, npm/@sentry/cli-linux-arm@2.30.2, npm/@sentry/cli-linux-i686@2.30.2, npm/@sentry/cli-linux-x64@2.30.2, npm/@sentry/cli-win32-x64@2.30.2, npm/@sentry/cli@2.30.2, npm/@sentry/core@7.107.0, npm/@sentry/esbuild-plugin@2.16.0, npm/@sentry/node@7.107.0, npm/@sentry/types@7.107.0, npm/@sentry/utils@7.107.0, npm/@types/pg@8.11.2, npm/agent-base@6.0.2, npm/ansi-styles@3.2.1, npm/anymatch@3.1.3, npm/array-buffer-byte-length@1.0.1, npm/arraybuffer.prototype.slice@1.0.3, npm/available-typed-arrays@1.0.7, npm/binary-extensions@2.3.0, npm/braces@3.0.2, npm/browserslist@4.23.0, npm/call-bind@1.0.7, npm/chalk@2.4.2, npm/chokidar@3.6.0, npm/color-convert@1.9.3, npm/color-name@1.1.3, npm/cross-spawn@6.0.5, npm/data-view-buffer@1.0.1, npm/data-view-byte-length@1.0.1, npm/data-view-byte-offset@1.0.0, npm/define-data-property@1.1.4, npm/define-properties@1.2.1, npm/detect-libc@2.0.2, npm/dotenv@16.4.5, npm/electron-to-chromium@1.4.715, npm/error-ex@1.3.2, npm/es-abstract@1.23.2, npm/es-define-property@1.0.0, npm/es-errors@1.3.0, npm/es-object-atoms@1.0.0, npm/es-set-tostringtag@2.0.3, npm/es-to-primitive@1.2.1, npm/esbuild@0.20.2, npm/escalade@3.1.2, npm/escape-string-regexp@1.0.5, npm/fill-range@7.0.1, npm/for-each@0.3.3, npm/function.prototype.name@1.1.6, npm/functions-have-names@1.2.3, npm/gensync@1.0.0-beta.2, npm/get-intrinsic@1.2.4, npm/get-symbol-description@1.0.2, npm/glob-parent@5.1.2, npm/glob@9.3.5, npm/globals@11.12.0, npm/globalthis@1.0.3, npm/gopd@1.0.1, npm/has-bigints@1.0.2, npm/has-flag@3.0.0, npm/has-property-descriptors@1.0.2, npm/has-proto@1.0.3, npm/has-symbols@1.0.3, npm/has-tostringtag@1.0.2, npm/hasown@2.0.2, npm/hosted-git-info@2.8.9, npm/https-proxy-agent@5.0.1, npm/internal-slot@1.0.7, npm/is-array-buffer@3.0.4, npm/is-arrayish@0.2.1, npm/is-bigint@1.0.4, npm/is-binary-path@2.1.0, npm/is-boolean-object@1.1.2, npm/is-callable@1.2.7, npm/is-data-view@1.0.1, npm/is-date-object@1.0.5, npm/is-negative-zero@2.0.3, npm/is-number-object@1.0.7, npm/is-number@7.0.0, npm/is-regex@1.1.4, npm/is-shared-array-buffer@1.0.3, npm/is-string@1.0.7, npm/is-symbol@1.0.4, npm/is-typed-array@1.1.13, npm/is-weakref@1.0.2, npm/isarray@2.0.5, npm/js-tokens@4.0.0, npm/jsesc@2.5.2, npm/json-parse-better-errors@1.0.2, npm/json5@2.2.3, npm/load-json-file@4.0.0, npm/lru-cache@10.2.0, npm/lru-cache@5.1.1, npm/magic-string@0.27.0, npm/memorystream@0.3.1, npm/minimatch@8.0.4, npm/minipass@4.2.8, npm/minipass@7.0.4, npm/nice-try@1.0.5, npm/node-fetch@2.7.0, npm/node-releases@2.0.14, npm/normalize-package-data@2.5.0, npm/normalize-path@3.0.0, npm/npm-run-all@4.1.5, npm/object-inspect@1.13.1, npm/object-keys@1.1.1, npm/object.assign@4.1.5, npm/parse-json@4.0.0, npm/path-key@2.0.1, npm/path-scurry@1.10.1, npm/path-type@3.0.0, npm/picomatch@2.3.1, npm/pidtree@0.3.1, npm/pify@3.0.0, npm/possible-typed-array-names@1.0.0, npm/progress@2.0.3, npm/proxy-from-env@1.1.0, npm/read-pkg@3.0.0, npm/readdirp@3.6.0, npm/regexp.prototype.flags@1.5.2, npm/safe-array-concat@1.1.2, npm/safe-regex-test@1.0.3, npm/semver@5.7.2, npm/semver@6.3.1, npm/set-function-length@1.2.2, npm/set-function-name@2.0.2, npm/shebang-command@1.2.0, npm/shebang-regex@1.0.0, npm/shell-quote@1.8.1, npm/side-channel@1.0.6, npm/slonik@37.3.1, npm/spdx-correct@3.2.0, npm/spdx-exceptions@2.5.0, npm/spdx-expression-parse@3.0.1, npm/spdx-license-ids@3.0.17, npm/string.prototype.padend@3.1.6, npm/string.prototype.trim@1.2.9, npm/string.prototype.trimend@1.0.8, npm/string.prototype.trimstart@1.0.8, npm/strip-bom@3.0.0, npm/supports-color@5.5.0, npm/to-regex-range@5.0.1, npm/tr46@0.0.3, npm/typed-array-buffer@1.0.2, npm/typed-array-byte-length@1.0.1, npm/typed-array-byte-offset@1.0.2, npm/typed-array-length@1.0.6, npm/unbox-primitive@1.0.2, npm/unplugin@1.0.1, npm/update-browserslist-db@1.0.13, npm/uuid@9.0.1, npm/validate-npm-package-license@3.0.4, npm/webidl-conversions@3.0.1, npm/webpack-sources@3.2.3, npm/webpack-virtual-modules@0.5.0, npm/whatwg-url@5.0.0, npm/which-boxed-primitive@1.0.2, npm/which-typed-array@1.1.15, npm/which@1.3.1, npm/yallist@3.1.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@drazisil
Copy link
Collaborator Author

@SocketSecurity ignore-all

@drazisil drazisil merged commit 74860bf into main Mar 23, 2024
9 of 14 checks passed
@drazisil drazisil deleted the switch-to-esbuild branch March 23, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant