-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update actions/setup-node digest to 1e60f62 - abandoned #1990
base: main
Are you sure you want to change the base?
Changes from all commits
610d309
e37eedf
27d7ecb
56937ba
0208b28
4adc91f
74860bf
290a21e
5b3e17a
396af2e
c215c19
d67bc72
77e01ef
6ef50e3
004095a
0ee1208
b1a25c2
a14625e
c77a948
0cb957b
69ae26a
00b7e75
50b10c6
20636c6
3a85d81
6bdcd97
97e6242
924a52c
0395fe6
54572cf
6492f95
31b25db
9053f3f
2e8ef49
47409e1
ea15375
f9d423d
113d775
265d3a2
cc0b63f
b22986b
e7fe037
8c1980d
155c18b
7c34644
dc749b5
8c88cd9
17c656c
eb31e33
0c7563d
4e5b6b3
006f1af
f8517d6
0d9ec37
4c88535
b43b5e0
1a43d06
b50ccd7
34953b2
1fa8b52
2c56bcd
676b041
b90a7fd
57edae9
3123c2c
b4123e4
aface92
3e76d6f
a2a2f22
b47a3a6
0129700
504c029
874ac69
98a5538
cc9cdcb
9f1418f
34fe63f
f21db72
2d4155a
483b7b7
e62e25a
08d4bbb
fe7c2ad
a180419
47d914b
077739c
5a2c5c2
fb72bb8
a537c7d
fa0c3fb
3c93907
b8a0fb7
deff04e
f47da8c
e1785bb
363db56
01b251d
369a6c9
dd26153
bfe3eea
ea868c7
4348bc1
406712e
eb44bcb
1302e39
a20086d
64aa658
11ac429
75b610f
c4bb26a
437ab75
6c9bbaf
4f96562
b1625e2
5a736b2
1fa79dd
72bd27c
3cf6daf
09c0c9b
86d95c2
d64f5d9
8c25668
afb16a8
0395651
c41f381
c1b74d8
f8ea845
5464d81
da5ed5b
1736c18
de998f8
3d5f4ef
e438cdd
52d6511
4e3d861
aa460c5
7645f6d
cb19397
80e41eb
de6ee78
54e7317
8859ce7
038706e
7daf7c2
2c1eacb
059b289
dfbe41c
1f180e7
e1cc0d3
876b224
f38864d
2de2c88
44a6ce4
fdeb72c
b43a370
4c2fc4e
5d21909
90d71db
0a6ad52
ded62b1
b0e3127
8e5537c
9f2c6cd
f811ff6
35b9ee7
4372d84
ef85ebb
7f5f0d6
8299f8a
9ae3056
a909bc9
d7b1ae0
3e6b2f2
c4020af
b29bc0e
1577a94
b85930a
11abaf2
9a05f7e
b36ca60
16bd4f6
236e341
49a1848
27925d4
ec34d7c
38a1480
22cb5d1
8bbc909
7124890
d3c98a7
4c1d23d
f14ab78
8acecac
e869f29
82d79a8
c8b2364
f11654c
915fa37
22b399a
a48a499
d7680f0
c5b812f
cff7361
1169d13
53e83b8
528e729
5aa301c
2f17038
3c14190
77923ec
a7c6d34
82b1c38
27b8f63
d90ed76
4ce02df
fa7a9bf
2f646bd
a023158
79d2edc
40f6623
e4b7c83
e78052b
46443ae
19c47b2
9895f04
7ab56e1
d858b0e
fbdf065
cf030c7
5454f92
95ff544
dacfb6e
40b26e6
3a76fab
a7a3183
40a52e3
bb0c345
b20861b
ffeb0d7
6a0535f
997603d
ccaa175
d1632be
399090a
44522c1
aa59d07
708579d
6bb1e0f
3430b35
c937f3d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
version = 1 | ||
|
||
[[analyzers]] | ||
name = "javascript" | ||
|
||
[analyzers.meta] | ||
environment = [ | ||
"nodejs", | ||
"vitest" | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
EXTERNAL_HOST= | ||
CERTIFICATE_FILE= | ||
PRIVATE_KEY_FILE= | ||
PUBLIC_KEY_FILE= |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Don't allow people to merge changes to these generated files, because the result | ||
# may be invalid. You need to run "rush update" again. | ||
pnpm-lock.yaml merge=text | ||
shrinkwrap.yaml merge=binary | ||
npm-shrinkwrap.json merge=binary | ||
yarn.lock merge=binary | ||
|
||
# Rush's JSON config files use JavaScript-style code comments. The rule below prevents pedantic | ||
# syntax highlighters such as GitHub's from highlighting these comments as errors. Your text editor | ||
# may also require a special configuration to allow comments in JSON. | ||
# | ||
# For more information, see this issue: https://github.com/microsoft/rushstack/issues/1088 | ||
# | ||
*.json linguist-language=JSON-with-Comments |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +0,0 @@ | ||
|
||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
extends: ["config:best-practices", ":automergeStableNonMajor"], | ||
packageRules: [ | ||
{ | ||
allowedVersions: "1.9.8", | ||
matchDatasources: ["docker"], | ||
matchPackageNames: [ | ||
// Prevent automatic updates from nginx:1.9.8 | ||
// While this image can still be found on DockerHub, | ||
// it is also archived at https://archive.org/details/nginx_1.9.8.tar | ||
// This is required to serve as a proxy to the [SChannel](https://web.archive.org/web/20230402130420/https://learn.microsoft.com/en-us/windows/win32/com/schannel) that Windows XP uses. | ||
// Windows XP is required support since the legacy client can not be upgraded or modified. | ||
"nginx", | ||
], | ||
}, | ||
], | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: Sentry Release | ||
|
||
on: | ||
workflow_dispatch: | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
release-sentry: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Install and test using npm | ||
run: | | ||
npm install | ||
export DATABASE_URL=$(npx pg-test start) | ||
npm run test --workspaces --if-present | ||
npx pg-test stop | ||
|
||
- name: Create Sentry release | ||
uses: getsentry/action-release@586b62368d564f25d694ce05fcb9cf53de65ac4f # v1 | ||
env: | ||
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} | ||
SENTRY_ORG: ${{ secrets.SENTRY_ORG }} | ||
SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }} | ||
# SENTRY_URL: https://sentry.io/ | ||
with: | ||
environment: production |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,52 +1,58 @@ | ||
name: Node.js CI | ||
name: Node.js | ||
|
||
on: | ||
push: | ||
branches: [main] | ||
pull_request: | ||
branches: [main] | ||
|
||
env: | ||
MCO_LOG_LEVEL: warn | ||
EXTERNAL_HOST: mcouniverse.com | ||
PRIVATE_KEY_FILE: thebeast/data/private_key.pem # These secrets are stored in the repository and are safe to "leak" | ||
CERTIFICATE_FILE: thebeast/data/mcouniverse.crt # These secrets are stored in the repository and are safe to "leak" | ||
PUBLIC_KEY_FILE: thebeast/data/pub.key # These secrets are stored in the repository and are safe to "leak" | ||
|
||
jobs: | ||
build: | ||
build-test: | ||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [18.x, 20.x, 21.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 | ||
with: | ||
fetch-depth: 0 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v3 | ||
- name: Use Node.js 22.x | ||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 | ||
with: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While updating the version of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The 'setup-node' GitHub Action hash has been changed. Make sure that the new change is compatible with your project's needs and replace the 'v4' comment with the corresponding version of 'setup-node' action used as per the new hash. Consider pinning to a released version/tag if possible for stability, unless there are specific reasons to point directly to a commit hash. |
||
node-version: ${{ matrix.node-version }} | ||
- run: npm ci install | ||
- name: Test | ||
run: npm run test:only | ||
node-version: 22.x | ||
- name: Install and test | ||
run: | | ||
npm install | ||
export DATABASE_URL=$(npx pg-test start) | ||
npm test | ||
npx pg-test stop | ||
env: | ||
CODECOV_UPLOAD_BUNDLE_TOKEN: ${{ secrets.CODECOV_UPLOAD_BUNDLE_TOKEN }} | ||
- name: Codecov | ||
env: # Or as an environment variable | ||
if: ${{ always() }} # using always() to always run this step because i am uploading test results and coverage in one step | ||
env: | ||
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
run: | | ||
pip install --user pytest | ||
pip install --user codecov-cli | ||
codecovcli --verbose create-commit --fail-on-error | ||
codecovcli --verbose create-report --fail-on-error | ||
codecovcli --verbose create-commit --fail-on-error | ||
codecovcli --verbose create-report --fail-on-error | ||
codecovcli do-upload --report-type test_results --file mcos.junit.xml | ||
codecovcli --verbose do-upload --fail-on-error --flag cli --name cli-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag connection --name connection-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag database --name database-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag gateway --name gateway-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag lobby --name lobby-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag login --name login-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag mcots --name mcots-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag nps --name nps-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag patch --name patch-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag persona --name persona-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag shard --name shard-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag transactions --name transactions-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag core --name core-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag shared --name shared-${{ matrix.node-version }} | ||
codecovcli --verbose do-upload --fail-on-error --flag shared-packets --name shared-packets-${{ matrix.node-version }} | ||
|
||
- uses: actions/upload-artifact@v3 | ||
- uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4 | ||
with: | ||
name: coverage_${{ matrix.node-version }} | ||
path: coverage |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
name: Release | ||
on: | ||
workflow_dispatch: | ||
push: | ||
branches: | ||
- master | ||
|
||
permissions: | ||
contents: read # for checkout | ||
|
||
jobs: | ||
release: | ||
name: Release | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write # to be able to publish a GitHub release | ||
issues: write # to be able to comment on released issues | ||
pull-requests: write # to be able to comment on released pull requests | ||
id-token: write # to enable use of OIDC for npm provenance | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 | ||
with: | ||
fetch-depth: 0 | ||
- name: Setup Node.js | ||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As per the change in the node.yml file, the setup-node action has been updated here as well. Similar to the previous comment, ensure its compatibility with the release workflow and consider adding an indicative version label for clearer understanding. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To maintain consistency across workflows, ensure the version of Node.js being used is the same in all workflows. If the Node version needs to be changed, it should be updated in all relevant places to avoid discrepancies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here too the 'setup-node' GitHub Action hash has been updated. Ensure its compatibility with the project dependencies and put the correct version of 'setup-node' action in the comment. It is recommended to use a version range or a specific version tag instead of a commit hash if the action follows Semantic Versioning. |
||
with: | ||
node-version: 'lts/*' | ||
- name: Install dependencies | ||
run: npm install | ||
- name: Verify the integrity of provenance attestations and registry signatures for installed dependencies | ||
run: npm audit signatures | ||
- name: Release | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
run: npx semantic-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have updated the setup-node action to a different commit hash. Please ensure that this new commit hash is compatible with your workflow and doesn't introduce any breaks or issues. I would also recommend adding a label indicating the version of the setup-node action that the new commit hash represents for better readability.