Divide "Shared with me" view into pending, accepted and declined sections #5177

elizavetaRa · 2021-05-31T08:15:20Z

Description

The "Shared with me" view shows 2 different lists for pending and accepted shares. On request user can see the declined files (clicking "show declined shares).

Motivation and Context

General UX improvement: Motivate the user to accept or decline the shares through better overview of the statuses and highlighted pending section.

How Has This Been Tested?

UI test scenario: Sharing multiple files through one testing account with another

test case 1: pending shares, 3 or less pending shares --> simple list of pending shares
test case 2: pending shares, more than 3 shares --> "show all", "show less" option
test case 3: no pending shares--> no pending shares list shown
test case 4: no accepted shares--> "You are currently not collaborating on other people's resources" message shown, "show declined shares" option appears at pending shares
test case 5: accepted shares exist--> list with accepted shares and option to show declined shares appears
test case 6: no declined shares--> "No declined files found" message appears
test case 7 declined shares exist --> list with declined shares shown on click of "show declined shares"

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

General view

update-docs · 2021-05-31T08:15:23Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

ownclouders · 2021-05-31T08:29:01Z

💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15842/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-31T08:30:28Z

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15842/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-31T08:33:58Z

💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15842/

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders · 2021-05-31T08:43:58Z

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15842/

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

ownclouders · 2021-05-31T09:09:01Z

💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15843/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-31T09:10:06Z

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15843/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-31T09:13:55Z

💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15843/

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders · 2021-05-31T09:26:58Z

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15843/

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

ownclouders · 2021-06-08T09:56:51Z

💥 Acceptance tests XGAPortrait1-Notifications failed. The build is cancelled...

ownclouders · 2021-06-08T12:10:17Z

💥 Acceptance tests XGAPortrait1-Notifications failed. The build is cancelled...

ownclouders · 2021-06-08T12:10:17Z

💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/16040/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

💥 Acceptance tests oc10-integration-notifications failed. The build is cancelled...

ownclouders · 2021-06-15T06:47:29Z

💥 Acceptance tests XGAPortrait1-Notifications failed. The build is cancelled...

ownclouders · 2021-06-15T06:48:28Z

💥 Acceptance tests SharingFilePermission failed. The build is cancelled...

ownclouders · 2021-06-15T06:50:48Z

💥 Acceptance tests XGAPortrait1 failed. The build is cancelled...

ownclouders · 2021-06-15T08:22:43Z

💥 Acceptance tests XGAPortrait1-Notifications failed. The build is cancelled...

elizavetaRa · 2021-06-15T08:26:56Z

@kulmann I rebased the pr but we again face the problem with updating the list by accepting/declining #5263 We also updated the server to 1.7.0, so it could be a server problem.

ownclouders · 2021-06-21T10:17:21Z

💥 Acceptance tests XGAPortrait1 failed. The build is cancelled...

kulmann · 2021-06-21T10:23:41Z

Hey @elizavetaRa, I already rebased to our current master and wanted to work on the PR in #5314 (opened a new PR since I can't push to CERN repos) - what kind of changes did you apply, except for rebasing?

kulmann · 2021-09-21T15:19:35Z

Thank you for your contribution! We finished the PR in #5814, closing this PR here as the functionality is in master now.

elizavetaRa mentioned this pull request May 31, 2021

Divide "Shared with me" view into pending, accepted and declined sections #4989

Closed

8 tasks

elizavetaRa added the Early-Adopter:CERN label Jun 7, 2021

elizavetaRa mentioned this pull request Jun 7, 2021

Shared with me: "Accept" and "Decline not implemented as batch actions #5204

Closed

elizavetaRa force-pushed the owncloud branch 2 times, most recently from b2d13de to 971decb Compare June 8, 2021 13:11

elizavetaRa mentioned this pull request Jun 8, 2021

Batch actions for Accept and Decline in Shared with me #5211

Closed

6 tasks

elizavetaRa force-pushed the owncloud branch 4 times, most recently from e7ce065 to d910770 Compare June 15, 2021 06:33

kulmann mentioned this pull request Jun 19, 2021

Shared with me split #5314

Closed

5 tasks

elizavetaRa added 2 commits June 21, 2021 10:54

cleanup, count of shares, disabled clicking by pending shares

172e549

rebase

2547cfe

elizavetaRa force-pushed the owncloud branch from cea90b3 to 2547cfe Compare June 21, 2021 10:13

butonic assigned kulmann Jul 1, 2021

butonic added Category:Enhancement Add new functionality Topic:UX-Design labels Jul 1, 2021

kulmann mentioned this pull request Sep 16, 2021

[full-ci] Shared with me split #5814

Merged

5 tasks

kulmann closed this Sep 21, 2021

diocas deleted the owncloud branch October 25, 2021 12:24

Divide "Shared with me" view into pending, accepted and declined sections #5177

Divide "Shared with me" view into pending, accepted and declined sections #5177

Conversation

elizavetaRa commented May 31, 2021 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

General view

update-docs bot commented May 31, 2021

ownclouders commented May 31, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 31, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 31, 2021

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders commented May 31, 2021

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

ownclouders commented May 31, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 31, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 31, 2021

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders commented May 31, 2021

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

ownclouders commented Jun 8, 2021

ownclouders commented Jun 8, 2021

ownclouders commented Jun 8, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented Jun 15, 2021

ownclouders commented Jun 15, 2021

ownclouders commented Jun 15, 2021

elizavetaRa commented May 31, 2021 •

edited

Loading