Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch actions for Accept and Decline in Shared with me #5211

Closed
wants to merge 1 commit into from

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Jun 8, 2021

Description

  • Share actions "Accept" and "Decline" implemented as batch actions
  • Delete batch action for shares removed

Related Issue

#5204

Motivation and Context

Usability improvement: consistency in representation with other actions on files; possibility to apply action to all shares at the same time

How Has This Been Tested?

Screenshots (if appropriate):

Bildschirmfoto vom 2021-06-08 16-37-42

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • [ x] Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • better implementation of triggerShareAction() in order to be reused for buttons ans batch actions. Currently duplicated in SharedWithMe.vue and BatchActions.vue

@update-docs
Copy link

update-docs bot commented Jun 8, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2021

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingPermissions2 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests OCISSharingPermissions3 failed. The build is cancelled...

@kulmann
Copy link
Member

kulmann commented Jun 30, 2021

Superseded by #5374, closing here

@kulmann kulmann closed this Jun 30, 2021
@diocas diocas deleted the batch branch October 25, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants