Divide "Shared with me" view into pending, accepted and declined sections #4989

elizavetaRa · 2021-04-20T21:12:12Z

Description

The "Shared with me" view shows 2 different lists for pending and accepted shares. On request user can see the declined files (clicking "show declined shares).

Motivation and Context

General UX improvement: Motivate the user to accept or decline the shares through better overview of the statuses and highlighted pending section.

How Has This Been Tested?

UI test scenario: Sharing multiple files through one testing account with another

test case 1: pending shares, 3 or less pending shares --> simple list of pending shares
test case 2: pending shares, more than 3 shares --> "show all", "show less" option
test case 3: no pending shares--> no pending shares list shown
test case 4: no accepted shares--> "You are currently not collaborating on other people's resources" message shown, "show declined shares" option appears at pending shares
test case 5: accepted shares exist--> list with accepted shares and option to show declined shares appears
test case 6: no declined shares--> "No declined files found" message appears
test case 7 declined shares exist --> list with declined shares shown on click of "show declined shares"

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Bug fix of Shared with me view: error on changing status of files #4946 required for normal functionality
Backend endpoints with getting separated lists for each status of share (currently devided in 3 lists through filtering of one list) get-endpoints for each status of shares (pending/accepted/declined) ocis#1957
Access to pending files should not be possible Prevent access to pending shares ocis#1958

General view

Declined section shown

update-docs · 2021-04-20T21:12:16Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pascalwengerter

Thank you so much for opening this PR! I'll take a closer look at the Vue component later on, some general comments ahead:

We pull our translations from https://www.transifex.com/, so please revert the changes to translations.json. Once your PR is merged, we'll translate all the strings in Transifex and then update them in the web repo
Could you open issues in the respective repos (oCIS/reva) for the "open tasks" in your PR and link them here? Then it's clearer who has to do what and if it has been done ;)

elizavetaRa · 2021-04-22T12:38:21Z

@pascalwengerter I linked the corresponding issues

kulmann

Hey, thank you for your contribution! Sorry that it took so long to review... Added some remarks. Also: we have a shareStatus const, which you can use in your code changes to use named variables instead integers for the different share status types. In the script you can use it as shareStatus.pending, shareStatus.accepted and shareStatus.declined. For using it also in the template you need to add shareStatus as a new line to the data object (after line 268 at the moment).

kulmann · 2021-05-05T10:23:30Z

packages/web-app-files/src/views/SharedWithMe.vue

+      <!-- Pending shares: show always -->
+      <div v-if="filterDataByStatus(activeFiles, 1).length > 0" id="pending-shares">
+        <div class="oc-app-bar shares-bar">
+          <h4><translate>Pending Shares</translate></h4>


We have a h1 for the page title (hidden, only for screen readers) and then no other h-tags, so technically (not talking about styling) this should be a h2, right?

kulmann · 2021-05-05T10:24:34Z

packages/web-app-files/src/views/SharedWithMe.vue

+            v-if="filterDataByStatus(activeFiles, 0).length === 0 && !getShowDeclined()"
+            id="show-declined-shares-btn"
+            @click="setShowDeclined(true)"
+            >Show declined shares</a


Please add the v-translate directive to the a tag

kulmann · 2021-05-05T10:27:39Z

packages/web-app-files/src/views/SharedWithMe.vue

-              class="uk-text-small oc-ml file-row-share-status-text uk-text-baseline"
-              v-text="getShareStatusText(resource.status)"
-            />
+            <a class="show-hide-pending" @click="setShowAllPending(true)"> Show all</a>


Can you switch this from an a tag to an oc-button tag with appearance="raw"? Reason: this is no navigation, but a modification/action on the current page. Therefor it's supposed to be a button, not a link.

kulmann · 2021-05-05T10:47:35Z

packages/web-app-files/src/views/SharedWithMe.vue

+      this.$forceUpdate()
+    },
+
+    getShowDeclined() {


I'd be fine with accessing the data prop directly in the template, without a getter. But up to you

kulmann · 2021-05-05T10:47:48Z

packages/web-app-files/src/views/SharedWithMe.vue

+      this.$forceUpdate()
+    },
+
+    getShowAllPending() {


Same here, I'd be fine with accessing the data prop directly in the template, without a getter. But up to you

kulmann · 2021-05-05T10:48:50Z

packages/web-app-files/src/views/SharedWithMe.vue

+    },
+
+    filterDataByStatus(data, status) {
+      return data.filter((item) => item.status === status)


you can simplify this to return data.filter((item) => item.status === status), because the result of filter is always an array (also an empty one if there are no matching elements)

kulmann · 2021-05-05T10:54:26Z

packages/web-app-files/src/views/SharedWithMe.vue

        })
        response = await response.json()
-        if (response.ocs.data.length > 0) {
+        if (response.ocs.data && response.ocs.data.length > 0) {


You can use if (response.ocs.data?.length > 0) { here (optional chaining, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining )

kulmann · 2021-05-05T10:56:49Z

packages/web-app-files/src/views/SharedWithMe.vue

@@ -241,18 +438,48 @@ export default {
            this.getToken
          )
          this.UPDATE_RESOURCE(sharedResource)
+          this.loadResources()


Please drop this line, we'll solve that outside this PR

pascalwengerter · 2021-05-06T09:51:20Z

@elizavetaRa just checked CI and it already fails in the lint step. If you run yarn lint --fix within the repo you'll see the enforced coding styles in version control and can commit them - after this, CI can continue with the other tests and we can focus on fixing the (perhaps broken) acceptance tests

ownclouders · 2021-05-06T11:59:07Z

💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15323/

ownclouders · 2021-05-06T11:59:21Z

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15323/

ownclouders · 2021-05-06T12:03:35Z

💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15323/

ownclouders · 2021-05-06T12:14:32Z

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15323/

elizavetaRa · 2021-05-06T12:20:59Z

@pascalwengerter I set the linting, some acceptance tests are indeed broken

kulmann · 2021-05-07T12:43:27Z

packages/web-app-files/src/views/SharedWithMe.vue

+}
+.show-hide-pending {
+  text-align: center;
+  padding-bottom: 12px;


Please don't use pixel values for padding / margin. You could either use our margin and padding classes from the design system on the element where you added the show-hide-pending class. I.e. remove the padding from the class here and add the respective padding class on the button where you used it. Documentation is available here: https://owncloud.design/#/Utilities/Padding The class that is interesting here for you is oc-pb-s, which stands for **p**adding **b**ottom **s**mall.

Another way would be to use the css variable for padding sizes.

This is important so that your theming config regarding spacing will take effect here as well.

You can see the default spacing pixel sizes here: https://owncloud.design/#/Design%20Tokens

kulmann · 2021-05-07T12:53:52Z

packages/web-app-files/src/views/SharedWithMe.vue

+}
+
+#pending-highlight {
+  background-color: aliceblue;


Could you check if there is a css variable from our color design tokens? Ideally we don't to have explicit colors anymore in the web code, so that theming works properly. https://owncloud.design/#/Design%20Tokens

kulmann · 2021-05-07T12:55:43Z

packages/web-app-files/src/views/SharedWithMe.vue

+}
+
+.margin-div {
+  margin-left: 24px;


This class is not needed. You can use our margin classes. oc-ml which uses the medium margin for **m**argin **l*eft.

ownclouders · 2021-05-18T13:11:46Z

💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15512/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-18T13:13:24Z

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15512/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-18T13:17:08Z

💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15512/

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders · 2021-05-18T13:29:05Z

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15512/

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

elizavetaRa · 2021-05-18T13:54:26Z

@kulmann please check.

By the way, in other vue files (for example FileLinkSidebar.vue, FileSharingSidebar.vue) there are also some pixel values for padding and margin.

kulmann · 2021-05-18T14:34:17Z

packages/web-app-files/src/views/SharedWithMe.vue

-
+    setShowDeclined(value) {
+      showDeclined = value
+      this.$forceUpdate()


Is the this.$forceUpdate() a mitigation for the change to showDeclined not being reactive / causing re-rendering of the view? If that's the case then it would be better to add showDeclined and showAllPending to the data prop after line 321. Then you don't need the getters and can skip the this.$forceUpdate() call. Same applies for the other setter.

ownclouders · 2021-05-18T15:59:10Z

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15518/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-18T15:59:24Z

💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15518/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-18T16:02:49Z

💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15518/

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders · 2021-05-18T16:16:34Z

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15518/

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

ownclouders · 2021-05-20T08:09:55Z

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15557/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-20T08:11:41Z

💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15557/

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-20T08:15:49Z

💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15557/

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders · 2021-05-20T08:22:35Z

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15557/

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

pascalwengerter · 2021-05-28T10:47:13Z

.gitignore

-# Themes
-/packages/web-runtime/themes/**
-!/packages/web-runtime/themes/owncloud/**
+# # Themes


@elizavetaRa @diocas please note that neither you nor us want the CERN theme in the ownCloud web master, esp. regarding licensing and logo files etc. Could you drop the respective commits from your fork in this PR? :)

This was not supposed to have happened. Those commits are only for our fork and are temporary.

@elizavetaRa please keep only your commits and rebase on the upstream, not on our fork.

No bad intent assumed ;) ping me/us if you need any suppor there

@pascalwengerter in future we will do the pull requests from cernbox/web, I closed this and opened the corresponding one with newest changes: #5177

ownclouders · 2021-05-31T07:48:01Z

💥 Acceptance tests SharingFolderPermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15839/

webUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-61.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-62.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-63.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-64.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-65.png

webUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-66.png

ownclouders · 2021-05-31T07:48:36Z

💥 Acceptance tests SharingFolderPermissionMultipleUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15839/

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-61.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-62.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-63.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-64.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-65.png

webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-66.png

ownclouders · 2021-05-31T07:52:16Z

💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15839/

webUISharingNotifications-shareWithGroups-feature-24.png

webUISharingNotifications-shareWithUsers-feature-21.png

webUISharingNotifications-shareWithUsers-feature-32.png

webUISharingNotifications-shareWithUsers-feature-40.png

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithGroups-feature-24.png

webUISharingNotificationsToRoot-shareWithUsers-feature-19.png

webUISharingNotificationsToRoot-shareWithUsers-feature-31.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-05-31T07:55:12Z

💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15839/

webUIFavorites-favoritesFile-feature-110.png

webUIFavorites-favoritesFile-feature-131.png

webUIFavorites-favoritesFile-feature-14.png

webUIFavorites-favoritesFile-feature-30.png

webUIFavorites-favoritesFile-feature-46.png

webUIFavorites-favoritesFile-feature-58.png

webUIFavorites-favoritesFile-feature-65.png

webUIFavorites-favoritesFile-feature-74.png

webUIFavorites-favoritesFile-feature-80.png

webUIFavorites-favoritesFile-feature-85.png

webUIFavorites-unfavoriteFile-feature-104.png

webUIFavorites-unfavoriteFile-feature-13.png

webUIFavorites-unfavoriteFile-feature-34.png

webUIFavorites-unfavoriteFile-feature-55.png

webUIFavorites-unfavoriteFile-feature-72.png

webUIFavorites-unfavoriteFile-feature-89.png

ownclouders · 2021-05-31T07:58:28Z

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15839/

webUISharingInternalGroups-shareWithGroups-feature-100.png

webUISharingInternalGroups-shareWithGroups-feature-182.png

webUISharingInternalGroups-shareWithGroups-feature-19.png

webUISharingInternalGroups-shareWithGroups-feature-196.png

webUISharingInternalGroups-shareWithGroups-feature-216.png

webUISharingInternalGroups-shareWithGroups-feature-228.png

webUISharingInternalGroups-shareWithGroups-feature-245.png

webUISharingInternalGroups-shareWithGroups-feature-260.png

webUISharingInternalGroups-shareWithGroups-feature-271.png

webUISharingInternalGroups-shareWithGroups-feature-293.png

webUISharingInternalGroups-shareWithGroups-feature-324.png

webUISharingInternalGroups-shareWithGroups-feature-325.png

webUISharingInternalGroups-shareWithGroups-feature-349.png

webUISharingInternalGroups-shareWithGroups-feature-350.png

webUISharingInternalGroups-shareWithGroups-feature-72.png

webUISharingInternalGroups-shareWithGroups-feature-73.png

webUISharingInternalGroups-shareWithGroups-feature-74.png

ownclouders · 2021-05-31T08:01:33Z

💥 Acceptance tests webUICreate failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15839/

webUICreateFilesFolders-createFile-feature-13.png

webUICreateFilesFolders-createFile-feature-19.png

webUICreateFilesFolders-createFile-feature-25.png

webUICreateFilesFolders-createFile-feature-31.png

webUICreateFilesFolders-createFolderEdgeCases-feature-19.png

webUICreateFilesFolders-createFolderEdgeCases-feature-20.png

webUICreateFilesFolders-createFolderEdgeCases-feature-21.png

webUICreateFilesFolders-createFolderEdgeCases-feature-22.png

webUICreateFilesFolders-createFolderEdgeCases-feature-23.png

webUICreateFilesFolders-createFolderEdgeCases-feature-24.png

webUICreateFilesFolders-createFolderEdgeCases-feature-25.png

webUICreateFilesFolders-createFolderEdgeCases-feature-26.png

webUICreateFilesFolders-createFolderEdgeCases-feature-43.png

webUICreateFilesFolders-createFolderEdgeCases-feature-44.png

webUICreateFilesFolders-createFolderEdgeCases-feature-60.png

webUICreateFilesFolders-createFolderEdgeCases-feature-61.png

webUICreateFilesFolders-createFolderEdgeCases-feature-62.png

webUICreateFilesFolders-createFolders-feature-12.png

webUICreateFilesFolders-createFolders-feature-22.png

webUICreateFilesFolders-createFolders-feature-27.png

webUICreateFilesFolders-createFolders-feature-32.png

webUICreateFilesFolders-createFolders-feature-39.png

webUICreateFilesFolders-createFolders-feature-44.png

webUICreateFilesFolders-createFolders-feature-49.png

pascalwengerter requested changes Apr 21, 2021

View reviewed changes

pascalwengerter changed the title ~~"Shared with me" view devided into pending, accepted and declined sections~~ Divide "Shared with me" view into pending, accepted and declined sections Apr 22, 2021

This was referenced Apr 22, 2021

get-endpoints for each status of shares (pending/accepted/declined) owncloud/ocis#1957

Closed

Prevent access to pending shares owncloud/ocis#1958

Closed

kulmann requested changes May 5, 2021

View reviewed changes

kulmann reviewed May 7, 2021

View reviewed changes

kulmann mentioned this pull request May 12, 2021

UX: Improve usability for received shares #3926

Closed

kulmann reviewed May 18, 2021

View reviewed changes

pascalwengerter reviewed May 28, 2021

View reviewed changes

elizavetaRa closed this May 31, 2021

elizavetaRa force-pushed the master branch from bcfd0bc to bb04092 Compare May 31, 2021 07:32

Divide "Shared with me" view into pending, accepted and declined sections #4989

Divide "Shared with me" view into pending, accepted and declined sections #4989

Conversation

elizavetaRa commented Apr 20, 2021 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Open tasks:

General view

Declined section shown

update-docs bot commented Apr 20, 2021

pascalwengerter left a comment

Choose a reason for hiding this comment

elizavetaRa commented Apr 22, 2021

kulmann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pascalwengerter commented May 6, 2021

ownclouders commented May 6, 2021

ownclouders commented May 6, 2021

ownclouders commented May 6, 2021

ownclouders commented May 6, 2021

elizavetaRa commented May 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ownclouders commented May 18, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 18, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 18, 2021

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders commented May 18, 2021

webUISharingAcceptShares-acceptShares-feature-100.png

webUISharingAcceptShares-acceptShares-feature-135.png

webUISharingAcceptShares-acceptShares-feature-16.png

webUISharingAcceptShares-acceptShares-feature-203.png

webUISharingAcceptShares-acceptShares-feature-235.png

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-15.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-267.png

webUISharingAcceptSharesToRoot-acceptShares-feature-299.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-366.png

webUISharingAcceptSharesToRoot-acceptShares-feature-397.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

elizavetaRa commented May 18, 2021

Choose a reason for hiding this comment

ownclouders commented May 18, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 18, 2021

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders commented May 18, 2021

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

ownclouders commented May 18, 2021

webUISharingAcceptShares-acceptShares-feature-100.png

elizavetaRa commented Apr 20, 2021 •

edited

Loading