Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared with me split #5314

Closed
wants to merge 3 commits into from
Closed

Shared with me split #5314

wants to merge 3 commits into from

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 19, 2021

Copied over from #5177 - needed to rebase and can't push to the origin of that PR.

Description

The "Shared with me" view shows 2 different lists for pending and accepted shares. On request user can see the declined files (clicking "show declined shares).

Motivation and Context

General UX improvement: Motivate the user to accept or decline the shares through better overview of the statuses and highlighted pending section.

How Has This Been Tested?

UI test scenario: Sharing multiple files through one testing account with another

  • test case 1: pending shares, 3 or less pending shares --> simple list of pending shares
  • test case 2: pending shares, more than 3 shares --> "show all", "show less" option
  • test case 3: no pending shares--> no pending shares list shown
  • test case 4: no accepted shares--> "You are currently not collaborating on other people's resources" message shown, "show declined shares" option appears at pending shares
  • test case 5: accepted shares exist--> list with accepted shares and option to show declined shares appears
  • test case 6: no declined shares--> "No declined files found" message appears
  • test case 7 declined shares exist --> list with declined shares shown on click of "show declined shares"

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

General view

Bildschirmfoto vom 2021-05-31 10-14-23

@update-docs
Copy link

update-docs bot commented Jun 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCISRename failed. The build is cancelled...

@kulmann
Copy link
Member Author

kulmann commented Jun 30, 2021

Closing here, out of date. Needs new rebase of #5177

@kulmann kulmann closed this Jun 30, 2021
@kulmann kulmann deleted the shared-with-me-split branch September 16, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants