Release 0.19.0 #3266
Comments
|
RC2 with updated translations: |
|
Exception
Crash log
|
|
@snappyapple632: That channel doesn't have any uploaded videos. |
|
You're right, it's a Topic, not a real channel. |
|
The "more" button with the help option on the top right disappears when you enter one of the screen from the navigaiton drawer or the search and press back to get to "what's new" again
|
|
Crash ! Exception
Crash log
Edit: it also says "url not supported" with RC, it's not the case with 0.18.7 |
@B0pol |
|
@jniniinoinoino: That channel doesn't exist anymore. |
|
@jniniinoinoino: Look at the first line of your crash log. It contains a link to a channel that doesn't exist anymore. |
We need better handling for these kinds of errors. When we see that the channel has been deleted, we should tell the user and ask whether to delete this channel. |
There is a PR about it TeamNewPipe/NewPipeExtractor#230
Thank you |
|
RC3: Fixed #3266 (comment) and #2790 |
Thanks for the reminder, I actually noticed this bug before but totally forgot about it. I really should've opened a separate issue for it, as it affects anything with a menu item... I'll try to push a fix for it in a bit. |
Just long press on Download button, and there you can access to Downloads |
|
Guys I found an issue. https://www.youtube.com/channel/UCHOgE8XeaCjlgvH0t01fVZg This channel has three live streams, but only one is shown in an up to date feed list (fast mode disabled). I only added this channel to test this. |
|
@Poolitzer it has only one listed in the videos tab, which is what's currently fetched. Should and will be fixed when we finish the tabs integration. |
|
@mauriciocolli It is, but down there. I take your PR takes the order from there then? So the live stream is in the list, just somewhere down, as it is in the videos tab from youtube.
|
|
Somebody could potentially squeeze #3275 in the release, but its fine to do it later. Just a minor addition. |
|
@Poolitzer: No, it's because it only takes the first loaded section due to data saving reasons (don't want to hammer services with even more requests). Let's see how we'll deal with live streams being buried in the list because they were started long ago when tabs are actually implemented. But by the looks of it, yet another request would need to be done to reliably get all the live streams, just what we want to avoid. |
|
@mauriciocolli okay, get it. so no easy fix anyway, if even. Want me to open a proper issue for this? |
|
Thinking again, do we really want to include them in the main page? We can safely ignore all these kinds of live streams, YouTube, for example, sort it by its start date so it doesn't keep cluttering your feed for days, or in this case, literally months. Another solution would be to create a dedicated section for live streams, which would only fetch the live streams section (/videos?view=2) from channels. Feel free to document all this information in a proper issue. |
|
in #3160 this string was added: NewPipe/app/src/main/res/values/strings.xml Line 596 in 55c577e This gets thrown in the users face through a toast when they change the use fast inexact setting and have the seek duration on a *5. Who is going to understand what that means? ExoPlayer? Is that thing gonna bite me??? This app is used by more or less normal people and, imo, our strings should more or less reflect that. Wouldn't it be enough if we said: |
|
@mauriciocolli in youtubes case, live streams are with their live chat important to have in the feed, since users might want to join this one time opportunity. Since NewPipe doesnt have live chats right now, I would say we can safely ignore them. I will open the issue later and put the discussion we had so far there, but I kinda need to focus on the post now. |
|
@XiangRongLin that bug that you mentioned should be fixed with #3281, can you test it on your end? |
Exception
Crash log
When i press this button NewPipe crash :( |
|
Fourth and hopefully last RC: NewPipe_v0.19.0_RC4.apk.zip |
|
Hi, Exception
Crash log
I have created a PR to fix this: #3292 |
|
@Stypox @mauriciocolli @TobiGr thanks for fix error, now app work well. |
|
@mauriciocolli I want to release 0.19.1 with some smaller improvements and fixes next week. We shouldn't add more and more stuff to 0.19.0. My plan is to release the new version tonight and the improved exception handling does not solve regressions introduced in this release as far as I can see. I don't have much time today and thus cannot review and test your changes in the way which is necessary. |
|
Getting post processing error file over 3GB 1080p60 version 0.19.0 rc5 |
|
@givemestella What error exactly? What video? Which Android version? |
|
@TobiGr: Yeah, I saw that a lot of things got added lately, I understand that. The major ones affected with this are people with slow/unreliable internet (or even occasional instability) because is likely that something will time out, and instead of a retry button, they'll see the report screen which is not the best situation for them. This can also be pretty much fixed in the extractor (this pull request only improves the detection, which fixes that as a side-effect), would this work out for you? It'd involve even fewer changes, should be even easier to test the changes. I'll open a pull request fixing that regardless. PS: Souldn't some of the latest merged pull requests be included in the changelog as well? Don't know if you forgot or chose not to, but IMO at least the bug involving the shared content would be worthy of a line in there. |
The error is that it seems to d/l the full 3.64GB (which it wasn't doing before when I tried with 0.18.7 - this release version got the http 200 download error at 2GB) but it fails the post processing part. When this happens It doubles the apparent file size in the app and then displays an error. The file is unplayable despite being the full 3.64GB. Don't want to give name of video |
|
@givemestella Did you delete the file already? If not, please go to NewPipe's download section and press on the three dot menu of this download. Use show error and please post the message here. If this is not possible anymore, please tell us how much free space was left on the device when you started the download. Did you download to internal storage or SD card?
No problem.
Both sides should be fixed. I'll gladly look at the PRs next week
Oh. yes, thanks for reminding me. I forgot to add those. @Poolitzer is going to kill me |
|
File deleted sorry 53.7GB free on SD card when I started downloading the 3.64GB file. |
|
@givemestella I was able to reproduce an error. However, I could only get a crash with 1080p 60 fps. Files with 720p or 360p and file sizes > 3.8GB didn't cause problems. This is a rare crash which happens only for large downloads on specific resolutions. That's why I do not consider this as blocking. Especially, because this release enables more users to download larger files without problems. |
and others
Changelog
New
Improved
Fixed
Development
DEBUG APK FOR TESTING
NewPipe_v0.19.0_RC5.apk.zip
Corresponding PR #3267
The text was updated successfully, but these errors were encountered: