Handle content not available exception more comprehensively #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciocolli
added
bug
TobiGr
reviewed
Mar 28, 2020
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
mauriciocolli
force-pushed
the
fix-not-found-handling
branch
from
3fbc85f
to
b4cabe2
Compare
TobiGr
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Long description of the changes in your PR
Some fragments were not handling these types of exceptions.
We should improve the display of
ContentNotAvailableExceptionexceptions in the future by showing more specific details, like not found.For now, a "Content unavailable" is better than a crash.
Relates to the following issue(s)