Remove search icon in search mode. Issue: #3183 #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as-skywalker/NewPipe into remove-search-icon-in-search
|
What's up with those commits? |
|
I amended the commit as I put the wrong issue number in the commit message, sorry. |
|
@jonas-skywalker Could you provide a debug apk. You'll have to zip it to upload it here |
|
@XiangRongLin: That's not really needed for such a small change. @jonas-skywalker: Next time I'd recommend to do an interactive rebase for editing the commit message, so that you won't have 3 commits. |
|
Alright, thank you very much for your feedback I'm just getting into github! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preview of the changes that match the requested change in issue #3183