Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change share title to differentiate multiple builds #3225

Merged
merged 2 commits into from
Mar 14, 2020

Conversation

mauriciocolli
Copy link
Contributor

The share title is currently hard coded and it was missed by #3133.

I was also inclined to create another variant for this, but a simple true in that if statement seems to be enough to force the default behavior when needed, not worth it.

  • Change share title as well to differentiate multiple builds
  • Move code with lower priority to the bottom of the file

@mauriciocolli mauriciocolli added the feature request Issue is related to a feature in the app label Mar 14, 2020
@TobiGr TobiGr merged commit a4babc1 into TeamNewPipe:dev Mar 14, 2020
@mauriciocolli mauriciocolli deleted the improve-build-branch branch March 17, 2020 01:13
This was referenced Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants