Improvements for the drawer header layout #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the right-aligned service names looks better and will be more consistent making the arrow be in the same spot for each service selected. |
|
Nice. I prefer the centred service name. |
|
Let's see then, use the reactions to vote for your favorite:
Open the images to see it better. |
Closed
TobiGr
reviewed
Mar 26, 2020
- Use a proper drop up/down arrow icon. - Move selected service views for better visibility. - Show the selected service icon next to its name. - Add a subtle fade background to the service name/icon for better readability.
People have voted, and that was the chosen design.
mauriciocolli
force-pushed
the
improve-drawer-layout
branch
from
39cc7d1
to
697f065
Compare
4 tasks
TobiGr
approved these changes
Apr 1, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some views are misaligned, specially when the app name is not the short one.
Visual differences
Autosizing doing its work when the app name is longer than usual:
Also, what do you prefer, central or right aligned service name/icon views?
I also noticed a minor bug related to the focus: when you press on the drawer header, due to how the menu items are removed/added, the focus just get transfered to another view (currently, the one that is below the drawer), causing an interruption in the animation of the pressed view.
It messes up the navigation using anything other than touch too (e.g. keyboard).
Won't fix it in this pull request though.