Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix: add feature_remover after apollo segmentation #217

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix: add feature_remover after apollo segmentation #217

merged 1 commit into from
Feb 25, 2022

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Feb 25, 2022 •
edited by satoshi-ota
Loading

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

PR Type

  • Bug Fix

Related Links

Description

The feature remover node is required after apollo_instance_segmentation.
https://github.com/tier4/autoware_launch/blob/782e836bbefea3d5d87a787af12fd9df248f2d43/perception_launch/launch/object_recognition/detection/lidar_based_detection.launch.xml#L29-L44

However, in camera_lidar_fusion_based_detection.launch.xml, there are no feature remove node.
https://github.com/tier4/autoware_launch/blob/782e836bbefea3d5d87a787af12fd9df248f2d43/perception_launch/launch/object_recognition/detection/camera_lidar_fusion_based_detection.launch.xml#L96-L103
So, the apollo & camera_lidar_fusion_based_detection did not work correctly.

In this PR I fixed this.

Review Procedure

(We checked on the real vehicle)

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@tkimura4
fix: add feature_remover after apollo segmentation
32e9f3d 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
satoshi-ota
satoshi-ota approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 347c1bf into tier4/universe Feb 25, 2022
@tkimura4 tkimura4 deleted the fix/add_feature_remover branch February 25, 2022 05:57
s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
@wep21
Remove clock publisher (tier4#217)
e9ae09c 
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
@kenji-miyake
Fixup for tier4#217 (tier4#254)
32e564c 
* Fixup for tier4#217

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
takayuki5168 added a commit that referenced this pull request May 26, 2022
@takayuki5168
Merge pull request #217 from tier4/auto/fix-behavior-path-tree
4b42908 
Auto/fix behavior path tree
takayuki5168 added a commit that referenced this pull request May 26, 2022
@tier4-autoware-private-bot @kenji-miyake
@tier4-autoware-public-bot @YamatoAndo @wep21 @zulfaqar-azmi-t4 @taikitanaka3 @h-ohta @yukkysaito @takayuki5168 @tkimura4 @pre-commit-ci @TakumiKozaka-T4 @yn-mrse
chore: sync upstream tier4 universe (#264)
d5a275b 
* chore: fix CI settings (#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync files (#180)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#184)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: add paricle param (#181)

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* chore: sync files (#185)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#186)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync system config (#187)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* chore: sync files (#189)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: replace system config in system launch (#188)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* feat: adds additional configuration flags for behavior_path_planner (#171)

* feat: adds additional configuration flags for behavior_path_planner

The additional configuration is used to allows avoidance over lane with same and
different direction, as well as allows safety margin between linestring and ego.

This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496
port.

Related PR:
autowarefoundation/autoware.universe#285
autowarefoundation/autoware.universe#287

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Change lateral_collision_margion to 1.0 to reflect changes.

The decision to change the parameter value to 1.0 is made after performing
drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting
between planning control team on 3rd of February 2022.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: slightly increase the safety buffer.

This increases the shift length to 1.7 + 0.5 * vehicle width.

The decision to increase is based on the discussion between planning team and
also the advice from the FI team.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* feat(behavior_velocity): add path marker visualization (#190)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: sync files (#193)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#194)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* chore: update workflow files name

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>

* chore: sync files (#195)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>

* feat: lateral controller param (#191)

* feat: define lat_controller_param_path

* feat: change for trajectory_follower params

* add args for lat_controller_param_path

* chore: fix wrong essential param to optional (#197)

* fix wrong param line

* move pointcloud_container_name param to optional

* fix: typo extra `>` (#199)

* Chore arrange perception rviz topics (#196)

* feat(autoware_launch): add occupancy grid vizualization

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(autoware_launch): add object recognition namespace to rviz

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: delete unused in control_launch (#200)

* fix: delete unused in control.launch.py

* fix: delete velocity_controller.param.yaml

* feat: add system_monitor parameters in sync-files (#201)

* chore: update settings of sync-files (#204)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat(control_launch): remove unnecessary params (#206)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (#208)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat(atutoware.rviz): disable selectable for pointcloud visualization (#207)

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* chore: sync files (#212)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat(behavior path planner): update params of behavior path for dynamic drivable area (#209)

* feat: load global param (#216)

* feat: load global param

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* chore: add comment about rosdistro migration

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: add feature_remover after apollo segmentation (#217)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* chore: sync files (#222)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-param-files.yaml

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore(perception_launch): update laserscan angle increment to pandar 64 level resolution (#220)

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

* feat: add enable option for image decompressor (#224)

* feat: add enable option for image decompressor

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci: fix flake8

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* feat(behavior_velocity): add merge from private marker (#223)

* feat(behavior_velocity): add merge from private marker

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): add factor text

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: expose traffic light model path arg (#225)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* feat(autoware_launch, simulator_launch): move perception modules to simulator.launch.xml (#227)

* feat(autoware_launch, simulator_launch): move perception modules to simulator.launch.xml

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove unnecessary comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(ndt_scan_matcher): add the tolerance of initial pose (#211)

* feat(ndt_scan_matcher): add the tolerance of initial pose

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* change param name

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: sync files (#229)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#230)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* remove tier4/proposal

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* change cron schedules

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* sync sync-files.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: add launch description for cpu usage adaptor (#210)

Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp>

* fix: delete aip dependents (#235)

* fix: delete aip dependents

* Update package.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix: disable awapi_vehicle_get_door_topic_state_monitor (#271)

Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: wep21 <wep21@users.noreply.github.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: TakumiKozaka-T4 <70260442+TakumiKozaka-T4@users.noreply.github.com>
Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@tkimura4
Merge pull request #217 from tier4/sync-upstream
7db4c1c 
feat: add launch description for cpu usage adaptor (#210)
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@tkimura4
fix: add feature_remover after apollo segmentation (#217)
63c0aca 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Feb 22, 2023
@brkay54
feat(lane_departure_checker): add optional neighbor lanelets paramete…
67e3389 
…rs (#217)

feat(lane_departure_checker): add optional neighbor lanelets parameters  (#217)

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@satoshi-ota satoshi-ota satoshi-ota approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkimura4 @satoshi-ota