Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use grapher config from API instead of from HTML in multiembedder #3884

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Aug 19, 2024

This PR switches the multi-embedder from using the chart config in the HTML file to the explicit grapher API.

The current (draft) version just uses the same url as the request came in on but that means that for local dev you need to have baked pages to use port :8788. It's probably nicer to have an explicit "grapher api url" setting that defaults to the same as the main page for prod but can be set differently for local dev or staging

@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 7ff4c04 to 718d193 Compare August 21, 2024 10:17
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 718d193 to 9575cd4 Compare August 21, 2024 11:03
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 9575cd4 to df54d29 Compare August 21, 2024 12:54
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from df54d29 to 31783c0 Compare August 21, 2024 15:09
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 31783c0 to 4969cea Compare August 21, 2024 15:18
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 4969cea to 935fde8 Compare August 22, 2024 15:53
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 935fde8 to daf3747 Compare August 22, 2024 15:56
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from daf3747 to efe49d6 Compare August 22, 2024 17:12
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from efe49d6 to a6efc86 Compare August 23, 2024 11:21
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from a6efc86 to 4f6ed11 Compare August 26, 2024 20:46
@danyx23 danyx23 marked this pull request as ready for review August 28, 2024 15:18
@danyx23 danyx23 force-pushed the render-thumbnails-by-uuid branch 2 times, most recently from 02cf775 to 2689b72 Compare September 10, 2024 11:31
@danyx23 danyx23 changed the base branch from render-thumbnails-by-uuid to graphite-base/3884 September 10, 2024 11:47
@danyx23 danyx23 changed the base branch from graphite-base/3884 to master September 10, 2024 11:48
Also adds two new mockSiteRouter routes so that
in local dev we can fetch grapher configs from the
DB instead of R2 via the admin API
Copy link
Contributor Author

danyx23 commented Sep 10, 2024

Merge activity

  • Sep 10, 8:00 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Sep 10, 8:01 AM EDT: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit 036fc1d into master Sep 10, 2024
19 of 21 checks passed
@danyx23 danyx23 deleted the multiembedder-use-config-api branch September 10, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants