Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 unify r2 config dirs #3945

Merged
merged 1 commit into from
Sep 10, 2024
Merged

🔨 unify r2 config dirs #3945

merged 1 commit into from
Sep 10, 2024

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Sep 10, 2024

The config paths were initially different at the top level for charts by uuid and those by slug for not good reason. This was fixed further upstack when the file was moved but not for the lowest pr in the stack.

Copy link
Contributor Author

danyx23 commented Sep 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite Graphite

@danyx23 danyx23 marked this pull request as ready for review September 10, 2024 08:01
@owidbot
Copy link
Contributor

owidbot commented Sep 10, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-unify-r2-config-paths

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-09-10 08:21:40 UTC
Execution time: 1.20 seconds

@danyx23 danyx23 merged commit 2ea2b29 into master Sep 10, 2024
14 of 19 checks passed
@danyx23 danyx23 deleted the unify-r2-config-paths branch September 10, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants