Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add fetching grapher configs by UUID #3879

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Aug 19, 2024

This PR adds fetching of grapher configs from R2 via a CF function by using grapher config UUIDs instead of slugs. Because we have UUIDs for all chart configs (e.g. the ones defined in the ETL grapher config layer) we can get them for charts other than standalone charts that are published (which are the only ones that have valid, unique urls)

@owidbot
Copy link
Contributor

owidbot commented Aug 19, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fetch-grapher-config-by-uuid

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-19 15:14:23 UTC
Execution time: 1.21 seconds

@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from d868f99 to df600ae Compare August 19, 2024 14:59
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 28327df to e5c06a1 Compare August 19, 2024 14:59
@danyx23 danyx23 marked this pull request as ready for review August 19, 2024 20:59
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from df600ae to 8a2e4a8 Compare August 21, 2024 10:17
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from e5c06a1 to 57c64eb Compare August 21, 2024 10:17
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from 8a2e4a8 to f18b0d2 Compare August 21, 2024 11:02
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch 2 times, most recently from 8d270f1 to 7c74a5b Compare August 21, 2024 12:54
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from 540fafb to 0c656d4 Compare August 21, 2024 15:09
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 7c74a5b to 1c77908 Compare August 21, 2024 15:09
@danyx23 danyx23 force-pushed the fetch-grapher-config-from-r2 branch from 0c656d4 to 484bd0d Compare August 21, 2024 15:17
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch 2 times, most recently from 29146e2 to 9e8ac98 Compare August 22, 2024 15:52
@danyx23 danyx23 changed the base branch from fetch-grapher-config-from-r2 to cf-function-consistent-redirects August 22, 2024 15:52
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 9e8ac98 to 30eb978 Compare August 22, 2024 17:12
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from afa702d to 9b7ba3d Compare August 23, 2024 11:21
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 30eb978 to 9a5e0e5 Compare August 23, 2024 11:21
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from 9b7ba3d to af2f857 Compare August 26, 2024 20:45
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 9a5e0e5 to ac04f5c Compare August 26, 2024 20:45
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from 546f675 to ecffac1 Compare September 5, 2024 12:31
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from ecffac1 to 2b761ca Compare September 5, 2024 18:37
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from 2b761ca to ade6496 Compare September 9, 2024 09:33
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from ade6496 to a8553c5 Compare September 9, 2024 11:53
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from a8553c5 to 563e74b Compare September 9, 2024 14:44
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from 563e74b to 275fa56 Compare September 10, 2024 07:59
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from 275fa56 to c902103 Compare September 10, 2024 08:06
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from c902103 to b0cd9d5 Compare September 10, 2024 09:55
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from b0cd9d5 to 2f44d84 Compare September 10, 2024 10:24
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from 2f44d84 to 3589dce Compare September 10, 2024 10:35
@danyx23 danyx23 force-pushed the cf-function-consistent-redirects branch from 3589dce to d25b1ef Compare September 10, 2024 10:54
@danyx23 danyx23 changed the base branch from cf-function-consistent-redirects to graphite-base/3879 September 10, 2024 11:14
@danyx23 danyx23 changed the base branch from graphite-base/3879 to master September 10, 2024 11:15
Copy link
Contributor Author

danyx23 commented Sep 10, 2024

Merge activity

  • Sep 10, 7:30 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Sep 10, 7:31 AM EDT: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit 756dd74 into master Sep 10, 2024
21 checks passed
@danyx23 danyx23 deleted the fetch-grapher-config-by-uuid branch September 10, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants