Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Render thumbnails for graphers by uuid #3880

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Aug 19, 2024

This PR duplicates the thumbnail rendering logic into the top level so that we can render pngs at /grapher/SLUG.png and svgs at /grapher/SLUG.svg. It also adds thumbnail rendering at /grapher/by-uuid/UUID.png and .svg.

The HTML rewriting (of og images) is changed to point to the new /grapher/SLUG.png route.

The old thumbnail rendering at /grapher/thumbnail/SLUG is kept for now so that existing fetches will still work until the various cached versions of the HTML have expired.

@danyx23 danyx23 marked this pull request as ready for review August 19, 2024 09:42
@owidbot
Copy link
Contributor

owidbot commented Aug 19, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-render-thumbnails-by-uuid

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-19 15:15:55 UTC
Execution time: 1.21 seconds

@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 28327df to e5c06a1 Compare August 19, 2024 14:59
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from e5c06a1 to 57c64eb Compare August 21, 2024 10:17
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 57c64eb to 8d270f1 Compare August 21, 2024 11:03
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 8d270f1 to 7c74a5b Compare August 21, 2024 12:54
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 7c74a5b to 1c77908 Compare August 21, 2024 15:09
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 1c77908 to 29146e2 Compare August 21, 2024 15:17
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 29146e2 to 9e8ac98 Compare August 22, 2024 15:52
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 9e8ac98 to 30eb978 Compare August 22, 2024 17:12
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 30eb978 to 9a5e0e5 Compare August 23, 2024 11:21
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 9a5e0e5 to ac04f5c Compare August 26, 2024 20:45
@danyx23 danyx23 changed the base branch from fetch-grapher-config-by-uuid to graphite-base/3880 September 10, 2024 11:31
@danyx23 danyx23 changed the base branch from graphite-base/3880 to master September 10, 2024 11:31
Copy link
Contributor Author

danyx23 commented Sep 10, 2024

Merge activity

  • Sep 10, 7:47 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Sep 10, 7:47 AM EDT: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit 8c2edee into master Sep 10, 2024
18 of 20 checks passed
@danyx23 danyx23 deleted the render-thumbnails-by-uuid branch September 10, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants