Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Upgrade to Assembly v1 🌝 #481

Merged
merged 58 commits into from
Oct 11, 2021
Merged

Upgrade to Assembly v1 🌝 #481

merged 58 commits into from
Oct 11, 2021

Conversation

malwoodsantoro
Copy link
Contributor

@malwoodsantoro malwoodsantoro commented Sep 3, 2021 •
edited by katydecorah
Loading

This branch:

  • Update repository to Node 14 (update package.json and .nvmrc) and npm 7 (update README.md requirements section)
  • Update assembly, mr-ui
  • Check docs-prose.css for styles that can be removed or adjusted:
    • Headings: v1 uses docs font-size and line-heights. We can also consolidate the double selectors to#docs-content .prose h*.
    • sticky is now in v1
    • Color overrides, use /dr-ui/guides/a11y/ page to check color contrast
    • limiter--wide limiter is deprecated in v1. Do we need this style or can we move it inline? (This is specific to PageLayout, but maybe should be addressed ahead?)
    • txt-spacing0 is now in v1
    • scroll-auto-m* in v1 scroll-auto is now overflow-auto. We should update these styles/classes to match.

To do

  • Create separate branches from this branch for individual components

QA checklist

  • No errors logged to console.
  • Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

Before merge

  • Add entry to CHANGELOG.md to describe changes.
  • If updating dependencies or creating a release, run npx browserslist@latest --update-db to update the browser data and commit any changes to package-lock.json.

katydecorah
katydecorah reviewed Sep 3, 2021
View reviewed changes
Copy link
Contributor

@katydecorah katydecorah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Before we begin individual component work, let's get these test passing:

  1. See line comment about the peer-deps test and how to fix.
  2. Update the snapshots: npm test -- -u and commit.
  3. Resolve merge conflict on package-lock.json.

(I won't explicitly approve this to prevent us from a accidental merge 😀)

README.md Show resolved Hide resolved
package.json Show resolved Hide resolved
@katydecorah katydecorah mentioned this pull request Sep 7, 2021
Merged
17 tasks
@malwoodsantoro malwoodsantoro mentioned this pull request Sep 7, 2021
Merged
17 tasks
Katy DeCorah added 2 commits September 8, 2021 10:40
Update CHANGELOG.md
a8a3bd4
LevelIndicator (#482)
720180a 
* Update Assembly v1, remove unneeded classes

* Remove unused align-middle class

* Prevent level squares from shrinking
@malwoodsantoro malwoodsantoro mentioned this pull request Sep 16, 2021
Merged
14 tasks
Katy DeCorah and others added 4 commits September 16, 2021 19:24
[Assembly v1] Update mr-ui@1.1.0 (#502)
d9c1ece 
* [Assembly v1] Update mr-ui

* Update CHANGELOG.md

* Update package-lock.json
[Assembly v1] Search (#500)
13af43e 
* [Assembly v1] Search

* Clean up
@malwoodsantoro
[Assembly v1] NumberedCodeSnippet (#504)
9b4b8c6 
* codemod changes

* increase line number contrast

* increase contrast of hide code text

* update snapshots

* Update src/components/numbered-code-snippet/show-hide-lines.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>
@malwoodsantoro
[Assembly v1] RelatedPage (#507)
c5ca835 
* codemod changes

* update snapshots

* remove a11y colors

* update snapshots
@malwoodsantoro malwoodsantoro mentioned this pull request Sep 17, 2021
Merged
14 tasks
Katy DeCorah and others added 18 commits September 20, 2021 10:50
[Assembly v1] PageLayout (#510)
67f3833 
* [Assembly v1] PageLayout

* Make `color-text` cascade from PageLayout instead

* Reduce changes

* Add stroke to select, make size match input--s

* Remove `color-text` from NavigationAccordion (allow the color to cascade from PageLayout)
@malwoodsantoro
[Assembly v1] Video (#511)
2b8d010 
* codemod changes

* update snapshots
@malwoodsantoro
[Assembly v1] Update catalog site (#512)
f378f02 
* codemode changes

* fix required badge contrast

* darken links in overview header

* remove overview header docs prose css

* change header background color and text color
Merge branch 'main' into assembly-v1-update
1d5f153 
* main:
  Move "I like..." category to bottom in `Feedback` component (#518)
  Bump tmpl from 1.0.4 to 1.0.5 (#514)
  Bump prismjs from 1.24.1 to 1.25.0 (#513)
Merge branch 'main' into assembly-v1-update
99a8945 
* main:
  Decrease Sentry tracesSampleRate  (#517)
Fix package-lock.json
64d7dae
Merge branch 'main' into assembly-v1-update
526579d 
* main:
  Updates `GuideGroupIndex` in `PageLayout` to use `CardContainer` to display full width cards (#519)
5.0.0-beta.0
00039a1
Update class in make-table-scroll plugin (#520)
4c7db7c
Update dependencies
f498a3b
5.0.0-beta.1
ce75191
mbx-assembly@1.2.0
4249f02
[Assembly v1] Update default theme to use color-text (#522)
d74f7a5
Fix border color and set icon color for lightText (#521)
0b9ba32
[Assembly v1] h2 fix (#523)
e32d40d 
* Add back `padding-top: 30px;`

* Create "Test pages" group on catalog site
5.0.0-beta.2
617c23a
[Assembly v1] Replace viewport and scroll classes in PageLayout (#524)
f6f0554 
* Fix deprecated viewport classes

* Fix overflow- class
5.0.0-beta.3
c4fe76a
@malwoodsantoro malwoodsantoro merged commit e75a178 into main Oct 11, 2021
@malwoodsantoro malwoodsantoro deleted the assembly-v1-update branch October 11, 2021 17:52
katydecorah pushed a commit that referenced this pull request Oct 25, 2021
Merge branch 'main' into assembly-v1-grouped-sub-pages
571d282 
* main:
  5.0.0
  update changelog
  Upgrade to Assembly v1 🌝 (#481)
katydecorah pushed a commit that referenced this pull request Oct 25, 2021
@malwoodsantoro
Upgrade to Assembly v1 🌝 (#481)
e13030c 
* update to Node 14

* add requirements section to readme.md

* update assembly and mr-ui

* remove font-size from docs-prose.css

* remove classes with position: sticky

* spacing fix

* replace limiter class

* replace limiter--wide class

* remove unused txt-spacing0 class

* update limiter--wide class

* remove fr-ui--feedback color-gray from docs-prose.css

* remove color-gray code class

* scroll-auto → overflow-auto

* remove double selectors

* add back heading prose selectors

* add mr-ui back as peerdependency

* update snapshots

* update package lock

* Update package-lock.json

* Update CHANGELOG.md

* LevelIndicator (#482)

* Update Assembly v1, remove unneeded classes

* Remove unused align-middle class

* Prevent level squares from shrinking

* [Assembly v1] Browser (#483)

* make w70 inline

* update snapshots

* updae package-lock.json

* update package-lock.json with assembly-v1-update branch

* Update src/components/browser/browser.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update browser snapshot

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] BackToTopButton (#486)

* [Assembly v1] Themes, Note, Tag (#487)

* [Assembly v1] Themes, Note, Tag

* Update CHANGELOG.md

* [Assembly v1] Card (#489)

* [Assembly v1] Card

* Update snapshots

* [Assembly v1] Phone (#488)

* [Assembly v1] Phone

* Fix border-radius on iOS/Safari by adding overflow-hidden and z-index

* Update background

* [Assembly v1] CardContainer (#493)

* [Assembly v1] CardContainer

* Update CHANGELOG.md

* [Assembly v1] Feedback (#496)

* codemod changes

* update snapshots

* Update src/components/feedback/feedback.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] CodeSnippetTitle (#491)

* codemod changes

* update snapshots

* update snapshots from assembly-v1-update

* update snapshots

* fix stacking behavior on small screens

* update snapshots

* [Assembly v1] OverviewHeader (#501)

* [Assembly v1] OverviewHeader

* Reduce changes

* Reduce changes

* Reduce changes

* Reduce changes

* [Assembly v1] OnThisPage (#497)

* codemod changes

* update snapshot

* [Assembly v1] NavigationAccordion (#499)

* [Assembly v1] ProductMenu (#503)

* [Assembly v1] Update mr-ui@1.1.0 (#502)

* [Assembly v1] Update mr-ui

* Update CHANGELOG.md

* Update package-lock.json

* [Assembly v1] Search (#500)

* [Assembly v1] Search

* Clean up

* [Assembly v1] NumberedCodeSnippet (#504)

* codemod changes

* increase line number contrast

* increase contrast of hide code text

* update snapshots

* Update src/components/numbered-code-snippet/show-hide-lines.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] RelatedPage (#507)

* codemod changes

* update snapshots

* remove a11y colors

* update snapshots

* [Assembly v1] PageLayout (#510)

* [Assembly v1] PageLayout

* Make `color-text` cascade from PageLayout instead

* Reduce changes

* Add stroke to select, make size match input--s

* Remove `color-text` from NavigationAccordion (allow the color to cascade from PageLayout)

* [Assembly v1] Video (#511)

* codemod changes

* update snapshots

* [Assembly v1] Update catalog site (#512)

* codemode changes

* fix required badge contrast

* darken links in overview header

* remove overview header docs prose css

* change header background color and text color

* Fix package-lock.json

* 5.0.0-beta.0

* Update class in make-table-scroll plugin (#520)

* Update dependencies

* 5.0.0-beta.1

* mbx-assembly@1.2.0

* [Assembly v1] Update default theme to use `color-text` (#522)

* Fix border color and set icon color for `lightText` (#521)

* [Assembly v1] h2 fix (#523)

* Add back `padding-top: 30px;`

* Create "Test pages" group on catalog site

* 5.0.0-beta.2

* [Assembly v1] Replace viewport and scroll classes in PageLayout (#524)

* Fix deprecated viewport classes

* Fix overflow- class

* 5.0.0-beta.3

Co-authored-by: Katy DeCorah <decorah@mapbox.com>
katydecorah pushed a commit that referenced this pull request Oct 25, 2021
@malwoodsantoro
Adjust spacing and size of subPages in GroupedGuides (#526)
1df1605 
* Adjust spacing and size of subPages in GroupedGuides

* Reduce changes

* Upgrade to Assembly v1 🌝 (#481)

* update to Node 14

* add requirements section to readme.md

* update assembly and mr-ui

* remove font-size from docs-prose.css

* remove classes with position: sticky

* spacing fix

* replace limiter class

* replace limiter--wide class

* remove unused txt-spacing0 class

* update limiter--wide class

* remove fr-ui--feedback color-gray from docs-prose.css

* remove color-gray code class

* scroll-auto → overflow-auto

* remove double selectors

* add back heading prose selectors

* add mr-ui back as peerdependency

* update snapshots

* update package lock

* Update package-lock.json

* Update CHANGELOG.md

* LevelIndicator (#482)

* Update Assembly v1, remove unneeded classes

* Remove unused align-middle class

* Prevent level squares from shrinking

* [Assembly v1] Browser (#483)

* make w70 inline

* update snapshots

* updae package-lock.json

* update package-lock.json with assembly-v1-update branch

* Update src/components/browser/browser.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update browser snapshot

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] BackToTopButton (#486)

* [Assembly v1] Themes, Note, Tag (#487)

* [Assembly v1] Themes, Note, Tag

* Update CHANGELOG.md

* [Assembly v1] Card (#489)

* [Assembly v1] Card

* Update snapshots

* [Assembly v1] Phone (#488)

* [Assembly v1] Phone

* Fix border-radius on iOS/Safari by adding overflow-hidden and z-index

* Update background

* [Assembly v1] CardContainer (#493)

* [Assembly v1] CardContainer

* Update CHANGELOG.md

* [Assembly v1] Feedback (#496)

* codemod changes

* update snapshots

* Update src/components/feedback/feedback.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] CodeSnippetTitle (#491)

* codemod changes

* update snapshots

* update snapshots from assembly-v1-update

* update snapshots

* fix stacking behavior on small screens

* update snapshots

* [Assembly v1] OverviewHeader (#501)

* [Assembly v1] OverviewHeader

* Reduce changes

* Reduce changes

* Reduce changes

* Reduce changes

* [Assembly v1] OnThisPage (#497)

* codemod changes

* update snapshot

* [Assembly v1] NavigationAccordion (#499)

* [Assembly v1] ProductMenu (#503)

* [Assembly v1] Update mr-ui@1.1.0 (#502)

* [Assembly v1] Update mr-ui

* Update CHANGELOG.md

* Update package-lock.json

* [Assembly v1] Search (#500)

* [Assembly v1] Search

* Clean up

* [Assembly v1] NumberedCodeSnippet (#504)

* codemod changes

* increase line number contrast

* increase contrast of hide code text

* update snapshots

* Update src/components/numbered-code-snippet/show-hide-lines.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] RelatedPage (#507)

* codemod changes

* update snapshots

* remove a11y colors

* update snapshots

* [Assembly v1] PageLayout (#510)

* [Assembly v1] PageLayout

* Make `color-text` cascade from PageLayout instead

* Reduce changes

* Add stroke to select, make size match input--s

* Remove `color-text` from NavigationAccordion (allow the color to cascade from PageLayout)

* [Assembly v1] Video (#511)

* codemod changes

* update snapshots

* [Assembly v1] Update catalog site (#512)

* codemode changes

* fix required badge contrast

* darken links in overview header

* remove overview header docs prose css

* change header background color and text color

* Fix package-lock.json

* 5.0.0-beta.0

* Update class in make-table-scroll plugin (#520)

* Update dependencies

* 5.0.0-beta.1

* mbx-assembly@1.2.0

* [Assembly v1] Update default theme to use `color-text` (#522)

* Fix border color and set icon color for `lightText` (#521)

* [Assembly v1] h2 fix (#523)

* Add back `padding-top: 30px;`

* Create "Test pages" group on catalog site

* 5.0.0-beta.2

* [Assembly v1] Replace viewport and scroll classes in PageLayout (#524)

* Fix deprecated viewport classes

* Fix overflow- class

* 5.0.0-beta.3

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* Update package-lock.json

* Update package-lock.json

* Update CHANGELOG.md

Co-authored-by: Mal Wood-Santoro <mal.wood@mapbox.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katydecorah katydecorah katydecorah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malwoodsantoro @katydecorah