Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Updates GuideGroupIndex in PageLayout to use CardContainer to display full width cards #519

Merged
merged 7 commits into from
Sep 23, 2021

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Sep 22, 2021

This PR updates GuideGroupIndex in PageLayout to use CardContainer to display full width cards. This helps reduce patterns and improve consistency. This PR will also generate a snapshot test for the grouped guides test case.

This PR will also fix an accessibility issue with the NavigationAccordion where the subpages were not properly nested: 6eb9fbf

Fixes #509

How to test

  1. nvm use && npm ci && npm start
  2. Visit /PageLayout test case, specifically Page layout: group index.
  3. npm run start-docs
  4. Visit http://localhost:8080/dr-ui/guides/grouped-guides/

QA checklist

  • No errors logged to console.
  • Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

Before merge

  • Add entry to CHANGELOG.md to describe changes.
  • If updating dependencies or creating a release, run npx browserslist@latest --update-db to update the browser data and commit any changes to package-lock.json.

@katydecorah katydecorah marked this pull request as draft September 22, 2021 17:09
@katydecorah katydecorah marked this pull request as ready for review September 22, 2021 19:22
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making our UI more consistent ✨

@katydecorah katydecorah merged commit 876e599 into main Sep 23, 2021
@katydecorah katydecorah deleted the grouped-guide-cards branch September 23, 2021 14:35
katydecorah pushed a commit that referenced this pull request Sep 23, 2021
* main:
  Updates `GuideGroupIndex` in `PageLayout` to use `CardContainer` to display full width cards (#519)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace code in GuideGroupIndex to use CardContainer (with fullWidthCards variant)
2 participants