Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Decrease Sentry tracesSampleRate #517

Merged
merged 12 commits into from
Sep 23, 2021
Merged

Conversation

malwoodsantoro
Copy link
Contributor

  • Decreases sentryPerformance tracesSampleRate default from 0.2 to 0.05 (from 20% to 5% of transactions)
  • Update @sentry/browser to latest
  • Update @sentry/tracing to latest

QA checklist

  • No errors logged to console.
  • Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

Before merge

  • Add entry to CHANGELOG.md to describe changes.
  • If updating dependencies or creating a release, run npx browserslist@latest --update-db to update the browser data and commit any changes to package-lock.json.

Copy link
Contributor

@katydecorah katydecorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our trusty tests are failing and we'll also want to merge this into main since it's not part of the Assembly v1 update. (I realize this is not always clear since it will eventually end up in the same release. Since this change is unrelated to Assembly v1, this will help keep our git and changelog history clear.)

  • Change the base branch with git: git rebase --onto main assembly-v1-update update-tracesSampleRate-sentry. You'll have some merge conflicts. Resolve the merge conflicts in package.json. Then run nvm use && npm i to resolve the merge conflicts in package-lock.json. Commit and push.
  • Switch the base branch of this PR: click "Edit" and then use the dropdown under the title of your PR.
  • Fix tests: Update the peerDependencies in package.json to match the version change for @sentry/browser
  • Fix tests: Update the value of tracesSampleRate found in analytics-shell.test.js

@malwoodsantoro malwoodsantoro changed the base branch from assembly-v1-update to main September 22, 2021 22:05
Copy link
Contributor

@katydecorah katydecorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

@katydecorah
Copy link
Contributor

Thanks for working through those changes! I'm going to merge this in :)

@katydecorah katydecorah merged commit ccdadb0 into main Sep 23, 2021
@katydecorah katydecorah deleted the update-tracesSampleRate-sentry branch September 23, 2021 14:17
katydecorah pushed a commit that referenced this pull request Sep 23, 2021
* main:
  Decrease Sentry tracesSampleRate  (#517)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants