This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katydecorah
suggested changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our trusty tests are failing and we'll also want to merge this into main
since it's not part of the Assembly v1 update. (I realize this is not always clear since it will eventually end up in the same release. Since this change is unrelated to Assembly v1, this will help keep our git and changelog history clear.)
- Change the base branch with git:
git rebase --onto main assembly-v1-update update-tracesSampleRate-sentry
. You'll have some merge conflicts. Resolve the merge conflicts in package.json. Then runnvm use && npm i
to resolve the merge conflicts inpackage-lock.json
. Commit and push. - Switch the base branch of this PR: click "Edit" and then use the dropdown under the title of your PR.
- Fix tests: Update the
peerDependencies
in package.json to match the version change for@sentry/browser
- Fix tests: Update the value of
tracesSampleRate
found inanalytics-shell.test.js
malwoodsantoro
force-pushed
the
update-tracesSampleRate-sentry
branch
from
September 22, 2021 22:05
8df4fc2
to
6ab34d3
Compare
katydecorah
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌻
Thanks for working through those changes! I'm going to merge this in :) |
katydecorah
pushed a commit
that referenced
this pull request
Sep 23, 2021
* main: Decrease Sentry tracesSampleRate (#517)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA checklist
#.#.#
.Open the test cases app locally on:
Before merge
npx browserslist@latest --update-db
to update the browser data and commit any changes to package-lock.json.